[QUEUED scylla next] scylla_coredump_setup: avoid coredump failure when hard limit of coredump is set to zero

12 views
Skip to first unread message

Commit Bot

<bot@cloudius-systems.com>
unread,
Mar 10, 2021, 12:28:19 PM3/10/21
to scylladb-dev@googlegroups.com, Takuya ASADA
From: Takuya ASADA <sy...@scylladb.com>
Committer: Avi Kivity <a...@scylladb.com>
Branch: next

scylla_coredump_setup: avoid coredump failure when hard limit of coredump is set to zero

On the environment hard limit of coredump is set to zero, coredump test
script will fail since the system does not generate coredump.
To avoid such issue, set ulimit -c 0 before generating SEGV on the script.

Note that scylla-server.service can generate coredump even ulimit -c 0
because we set LimitCORE=infinity on its systemd unit file.

Fixes #8238

Closes #8245

---
diff --git a/dist/common/scripts/scylla_coredump_setup b/dist/common/scripts/scylla_coredump_setup
--- a/dist/common/scripts/scylla_coredump_setup
+++ b/dist/common/scripts/scylla_coredump_setup
@@ -87,7 +87,8 @@ WantedBy=multi-user.target
run('sysctl -p /etc/sysctl.d/99-scylla-coredump.conf', shell=True, check=True)

fp = tempfile.NamedTemporaryFile()
- fp.write(b'kill -SEGV $$')
+ fp.write(b'ulimit -c unlimited\n')
+ fp.write(b'kill -SEGV $$\n')
fp.flush()
p = subprocess.Popen(['/bin/bash', fp.name], stdout=subprocess.PIPE)
pid = p.pid

Commit Bot

<bot@cloudius-systems.com>
unread,
Mar 10, 2021, 5:06:28 PM3/10/21
to scylladb-dev@googlegroups.com, Takuya ASADA
From: Takuya ASADA <sy...@scylladb.com>
Committer: Avi Kivity <a...@scylladb.com>
Branch: master
Reply all
Reply to author
Forward
0 new messages