[QUEUED scylladb next] s3/client: Always retry http requests

0 views
Skip to first unread message

Commit Bot

<bot@cloudius-systems.com>
unread,
Jun 27, 2024, 6:14:53 AMJun 27
to scylladb-dev@googlegroups.com, Pavel Emelyanov
From: Pavel Emelyanov <xe...@scylladb.com>
Committer: Nadav Har'El <n...@scylladb.com>
Branch: next

s3/client: Always retry http requests

Real S3 server is known to actively close connections, thus breaking S3
storage backend at random places. The recent http client update is more
robust against that, but the needed feature is OFF by default.

refs: scylladb/seastar#1883

Signed-off-by: Pavel Emelyanov <xe...@scylladb.com>

Closes scylladb/scylladb#19461

---
diff --git a/utils/s3/client.cc b/utils/s3/client.cc
--- a/utils/s3/client.cc
+++ b/utils/s3/client.cc
@@ -134,7 +134,7 @@ future<semaphore_units<>> client::claim_memory(size_t size) {
}

client::group_client::group_client(std::unique_ptr<http::experimental::connection_factory> f, unsigned max_conn)
- : http(std::move(f), max_conn)
+ : http(std::move(f), max_conn, http::experimental::client::retry_requests::yes)
{
}

Commit Bot

<bot@cloudius-systems.com>
unread,
Jun 27, 2024, 10:50:18 AMJun 27
to scylladb-dev@googlegroups.com, Pavel Emelyanov
From: Pavel Emelyanov <xe...@scylladb.com>
Committer: Nadav Har'El <n...@scylladb.com>
Branch: master
Reply all
Reply to author
Forward
0 new messages