[PATCH v1 0/4] Fixes for gossiper conversion to host id

8 views
Skip to first unread message

Gleb Natapov

<gleb@scylladb.com>
unread,
Apr 7, 2025, 3:41:12 AMApr 7
to scylladb-dev@googlegroups.com
The series contains fixes to gossiper conversion to host id. There are
two fixes where we could erroneously send outdated entry in a gossiper
message and a fix for force_remove_endpoint which was not converted to
work on host id and this caused it to not delete the entry in some cases
(in replace with the same ip case).

CI: https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/16615/

Also in scylla-dev gleb/host-id-fixes

Gleb Natapov (4):
gossiper: do not send outdated endpoint in gossiper round
gossiper: move force_remove_endpoint to work on host id
gossiper: change make_random_gossip_digest to return value instead of
modifying passed parameter
gossiper: send newest entry in a digest message

test/cluster/test_gossiper_orphan_remover.py | 3 +-
gms/gossiper.hh | 5 +--
api/gossiper.cc | 2 +-
gms/gossiper.cc | 39 +++++++++++++-------
service/storage_service.cc | 9 ++---
5 files changed, 34 insertions(+), 24 deletions(-)

--
2.47.1

Benny Halevy

<bhalevy@scylladb.com>
unread,
Apr 7, 2025, 9:46:40 AMApr 7
to Gleb Natapov, scylladb-dev@googlegroups.com
LGTM, but who else should review this?

Gleb Natapov

<gleb@scylladb.com>
unread,
Apr 7, 2025, 9:47:49 AMApr 7
to Benny Halevy, scylladb-dev@googlegroups.com, avi@scylladb.com
On Mon, Apr 07, 2025 at 04:46:32PM +0300, Benny Halevy wrote:
> LGTM, but who else should review this?
>
Avi?
--
Gleb.

Avi Kivity

<avi@scylladb.com>
unread,
Apr 7, 2025, 10:05:14 AMApr 7
to Gleb Natapov, scylladb-dev@googlegroups.com
Queueueueueueud

On Mon, 2025-04-07 at 10:26 +0300, 'Gleb Natapov' via ScyllaDB development wrote:
Reply all
Reply to author
Forward
0 new messages