Add-on doesn't warn in case of bad file name

2 views

Skip to first unread message

PhL38F

unread,

Nov 21, 2011, 12:43:59 AM11/21/11

to screengrab

Hi!

Thanks for this add-on! I find it useful to not have to go through
full screen shots, especially on long pages.

I just want to raise a small issue as said in message title: Add-on
doesn't warn in case of bad file name.

I experimented that under Ubuntu when trying to save a picture from a
page displaying the content of the program for a radio broadcast. That
broadcast happened to occur in 5 episodes. Thus the page contained the
character sequence "5/5" in the name automatically proposed for saving
the picture. Obviously, this would translate in the Unix system into
"name of a file" (5-end_of_the_name.png) inside a
"directory" (beginning-of-the-name-5/). The system would not complain
but not register the file, just stubbornly remain on the same window
while I (stupidly) click again and again. Just until I realized that
the name got a slash inside the name ... and tried to move forward by
correcting it. It worked!

I would recommend that this behaaviour be changed to either
- warn the user that he/she is trying to create a file in a directory
that doesn't exist (naming the directory, that should be easy using
the return code of the "open" function trying to access the file) or
- warn the user that he/she is trying to create a file with a name
that doesn't respect the naming conventions of the system (by
analyzing it firsthand) or
- change the name so that all characters that are "weird" (for the
target system) get escaped for that system (by analyzing AND updating
the name)

In any case, the add-on should not stay as is as trying to use the
Screengrab menu from the icon in the status line just didn't do
anything in such conditions, not even open the Sav file pop-up
window...

For the record, I am using Screengrab v0.96.3 on Firefox 3.5.7 in the
context of Ubuntu 9.10 (Karmic), build 2.6.31-14-generic with Gnome
2.28.1 desktop environment.