autocomplete.XYZ.ignorecase=1 ignored

[Jos]

I think we lost the functionality of setting the autocomplete.XYZ.ignorecase for a specific language in the latest version(s). The code in SciTEProps.cxx  was changed to:

sval = props.GetNewExpandString("autocomplete.*.ignorecase");
autoCompleteIgnoreCase = sval == "1";
sval = props.GetNewExpandString(Join("autocomplete.", "*", ".ignorecase"));
if (sval != "")
autoCompleteIgnoreCase = sval == "1";

Which use to be:

sprintf(key, "autocomplete.%s.ignorecase", "*");
sval = props.GetNewExpandString(key);
autoCompleteIgnoreCase = sval == "1";
sprintf(key, "autocomplete.%s.ignorecase", language.c_str());
sval = props.GetNewExpandString(key);
if (sval != "")
autoCompleteIgnoreCase = sval == "1";

As you can se we lost the link to the current language.

Shouldn't this code do do it like done with callTipIgnoreCase?:

sval = FindLanguageProperty("autocomplete.*.ignorecase");
autoCompleteIgnoreCase = sval == "1";

Cheers,

Jos

[Neil Hodgson]

Jos:

> Shouldn't this code do do it like done with callTipIgnoreCase?:
> sval = FindLanguageProperty("autocomplete.*.ignorecase");
> autoCompleteIgnoreCase = sval == "1";

OK. I was trying to avoid fixed size buffers and sprintf and made a mistake.

Updated with FindLanguageProperty:

https://sourceforge.net/p/scintilla/scite/ci/03a55c2240e9a52da1817f8cb2b9b059614a264b/

There are other properties with the same pattern that could be simplified.

Neil

[Jos]

Thanks for the quick fix Neil! :) 

Op woensdag 15 maart 2023 om 06:34:53 UTC+1 schreef Neil Hodgson: