crash

[Okko Willeboordse]

Hello,

Both Sc32_552.exe and Sc552.exe crash upon the following;

 - open attached file

 - hold the DOWNARROW key or scroll down with the mouse scroll wheel or scroll bar up to the point as shown in CrashDialog.png

The file is publically available at;

https://github.com/eProsima/Fast-DDS/blob/v3.1.0/include/fastdds/rtps/attributes/ReaderAttributes.hpp

[Neil Hodgson]

 - open attached file

 - hold the DOWNARROW key or scroll down with the mouse scroll wheel or scroll bar up to the point as shown in CrashDialog.png

This occurs with Unix-style \n line ends but doesn't (or is less likely) with Windows \r\n line ends and it depends on the range being styled so may not happen if (for example) you move straight to the file end then move back to this position.

The bug is actually in handling an empty document comment keyword. Some document comment tools use XML like tags such as <summary>. The code sees the < and then checks the next text against the defined keywords. There are other potential results here: if the document is scrolled to the end to avoid the crash then the line after the '<' is changed then the rest of the document may appear as an invalid documentation comment keyword.

A reasonable fix appears to be to not treat a '<' followed by whitespace like a line and as the start of a keyword, so that has been committed as.

https://github.com/ScintillaOrg/lexilla/commit/5bd3f0fa390aaad1901d1d84e577b1c8bf9e5003

An updated binary is available from
https://www.scintilla.org/wscite.zip Windows executable (64-bit)

Due to this change the releases will be delayed so may appear tomorrow October 19 instead of today.

Neil