[scintilla:feature-requests] #1588 If the SC_MOD_INSERTCHECK notification handler sends an empty string via SCI_CHANGEINSERTION, you should not attempt to insert anything.

1 view
Skip to first unread message

Schreiner

unread,
Jun 16, 2026, 11:17:13 AMJun 16
to scintill...@googlegroups.com

[feature-requests:#1588] If the SC_MOD_INSERTCHECK notification handler sends an empty string via SCI_CHANGEINSERTION, you should not attempt to insert anything.

Status: open
Group: Initial
Created: Tue Jun 16, 2026 03:17 PM UTC by Schreiner
Last Updated: Tue Jun 16, 2026 03:17 PM UTC
Owner: nobody
Attachments:

If a decision is made in an SC_MOD_INSERTCHECK notification handler to prevent the desired insertion, an empty string can be sent via SCI_CHANGEINSERTION, but no attempt should then be made to insert it. Currently, this results in an empty undo entry and thus also changes the savepoint. Therefore, it would be preferable to simply do the same as when passing insertLength = 0 to Document::InsertString.

Sent from sourceforge.net because scintill...@googlegroups.com is subscribed to https://sourceforge.net/p/scintilla/feature-requests/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/scintilla/admin/feature-requests/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

Neil Hodgson

unread,
Jun 18, 2026, 12:14:54 AMJun 18
to scintill...@googlegroups.com
  • labels: --> scintilla, notification
  • Group: Initial --> Committed
  • Comment:

Committed equivalent code with [54d811].

[feature-requests:#1588] If the SC_MOD_INSERTCHECK notification handler sends an empty string via SCI_CHANGEINSERTION, you should not attempt to insert anything.

Status: open
Group: Committed
Labels: scintilla notification

Created: Tue Jun 16, 2026 03:17 PM UTC by Schreiner
Last Updated: Tue Jun 16, 2026 03:17 PM UTC
Owner: nobody
Attachments:

Reply all
Reply to author
Forward
0 new messages