[ scintilla-Feature Requests-2010095 ] Multiple bug fixes and feature enhancements

0 views
Skip to first unread message

SourceForge.net

unread,
Apr 28, 2009, 1:10:03 AM4/28/09
to nor...@sourceforge.net
Feature Requests item #2010095, was opened at 2008-07-04 07:35
Message generated for change (Comment added) made by nyamatongwe
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=352439&aid=2010095&group_id=2439

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: Completed
>Status: Closed
Priority: 5
Private: No
Submitted By: Jason Oster (parasytic)
Assigned to: Neil Hodgson (nyamatongwe)
Summary: Multiple bug fixes and feature enhancements

Initial Comment:
Here is a complete list of the work I've down on Scintilla over the past few weeks. The attachment contains the original files (from the current CVS repository), the fully patched files, and all individual diffs.


LexCPP.cxx:
* Fix fold point on the last line in the document (related to #1943442)

LexCSS.cxx:
* Fix fold point on the last line in the document (related to #1943442)

LexHTML.cxx:
* Fix fold point on the last line in the document (#1943442)
* Fix coloring of word characters at the end of the document.
* Add support for PHP 5.3.0 NOWDOC syntax, and fix delimiter handling of HEREDOC syntax.
* Fix PHP </script> handling. (related to #1839569)
* Fix line break handling with string variables at the end of lines.


The fold point fixes should also be applied to other lexers with similar problems. I have not had a use for any other lexer yet, so it is not currently a priority for me.

----------------------------------------------------------------------

>Comment By: Neil Hodgson (nyamatongwe)
Date: 2009-04-28 15:10

Message:
Released in 1.78.

----------------------------------------------------------------------

Comment By: Jason Oster (parasytic)
Date: 2008-07-09 00:39

Message:
Logged In: YES
user_id=643076
Originator: YES

Ah, thank you for pointing that out. I was wondering why the C++ folding
code was so much different from HTML/CSS. This is good to know, I will have
to study the fold structure more closely.

----------------------------------------------------------------------

Comment By: Neil Hodgson (nyamatongwe)
Date: 2008-07-06 16:55

Message:
Logged In: YES
user_id=12579
Originator: NO

This fold modification can (temporarily) remove a fold point on the last
visible line, causing folded text to unfold. For example, see
http://www.scintilla.org/beforeType.PNG
http://www.scintilla.org/beforeType.PNG

Maintaining the fold structure is much more important than ensuring the
last line looks correct since the user may have spent some effort arranging
the folding. The CSS and HTML versions of the fold patch may be better but
its the C++ folder that has been worked on the most - I couldn't find an
example that folded better with the patch than without. It may actually be
simpler to just limit the display of the fold structure on the final line.

Committed the other changes.


----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=352439&aid=2010095&group_id=2439

Reply all
Reply to author
Forward
0 new messages