Upcoming 3.7.1

[Neil Hodgson]

A new version, 3.7.1 should be released in around 5 days on Sunday December 4.

Change list:

• The Scintilla namespace is no longer applied to struct definitions in Scintilla.h even when SCI_NAMESPACE defined. Client code should not define SCI_NAMESPACE.
• Structure names in Scintilla.h without prefixes are deprecated and will now only be usable with INCLUDE_DEPRECATED_FEATURES defined.
Use the newer names with the "Sci_" prefix:
CharacterRange → Sci_CharacterRange
TextRange → Sci_TextRange
TextToFind → Sci_TextToFind
RangeToFormat → Sci_RangeToFormat
NotifyHeader → Sci_NotifyHeader
• Previously deprecated features SC_CP_DBCS, SCI_SETUSEPALETTE. and SCI_GETUSEPALETTE have been removed and can no longer be used in client code.
• Accessibility support allowing screen readers to work added on GTK+ and Cocoa.
• Textual tags may be displayed to the right on folded lines with SCI_TOGGLEFOLDSHOWTEXT. This is commonly something like "{ ... }" or "<tr>...</tr>". It is displayed with the STYLE_FOLDDISPLAYTEXT style and may have a box drawn around it with SCI_FOLDDISPLAYTEXTSETSTYLE.
• A mouse right-click over the margin may send an SCN_MARGINRIGHTCLICK event. This only occurs when popup menus are turned off. SCI_USEPOPUP now has three states: SC_POPUP_NEVER, SC_POPUP_ALL, or SC_POPUP_TEXT.
• INDIC_POINT and INDIC_POINTCHARACTER indicators added to display small arrows underneath positions or characters.
• Added alternate appearance for visible tabs which looks like a horizontal line. Controlled with SCI_SETTABDRAWMODE. Feature #1165.
• On Cocoa, a modulemap file is included to allow Scintilla to be treated as a module. This makes it easier to use Scintilla from the Swift language.
• Baan folder accommodates sections and lexer fixes definition of SCE_BAAN_FUNCDEF.
• EDIFACT lexer and folder added. Feature #1166.
• JSON folder fixed where it didn't resume folding with the correct fold level.
• Matlab folder based on syntax instead of indentation so more accurate. Bug #1692.
• YAML lexer fixed style of references and keywords when followed by a comment. Bug #1872.
• Margin click to select line now clears rectangular and additional selections.
• Fixed a NULL access bug on GTK+ where the scrollbars could be used during destruction. Bug #1873.
• A potential bug on GTK+ fixed where asynchronous clipboard could be delivered after its target Scintilla instance was destroyed.
• Cocoa IME made more compliant with documented behaviour to avoid bugs that caused huge allocations. Bug #1881.
• On Win32 fix EM_SETSEL to match Microsoft documentation.. Bug #1886.
• SciTE on GTK+ allows localising tool bar tool tips. Feature #1167.
• SciTE on Windows restores focus to edit pane after closing user strip.
• SciTE measures files larger that 2 GB which allows it to refuse to open huge files more consistently and to show better warning messages.

Please report any new bugs.

Available from the Mercurial repositories:
hg clone http://hg.code.sf.net/p/scintilla/code scintilla
hg clone http://hg.code.sf.net/p/scintilla/scite
and from
http://www.scintilla.org/scite.zip Source
http://www.scintilla.org/wscite.zip Windows executable

Neil

[Colomban Wendling]

Hi,

> • Accessibility support allowing screen readers to work added on GTK+

I think there is a few issues on the reference count of the accessible
object on GTK < 3.8. I'll double check that, but I'm afraid I won't
have much time before Saturday.

Regards,
Colomban

[Neil Hodgson]

Colomban Wendling:

> I think there is a few issues on the reference count of the accessible
> object on GTK < 3.8. I'll double check that, but I'm afraid I won't
> have much time before Saturday.

Which direction is the refcount potentially wrong? If it causes excessive survival then its not fatal. If it drops too early then is it possible there will be crashes?

Neil

[Colomban Wendling]

Unfortunately it would be not enough references I think, e.g. not owning
its own ref, yet dropping it. Something like that:

> diff --git a/gtk/ScintillaGTKAccessible.cxx b/gtk/ScintillaGTKAccessible.cxx
> --- a/gtk/ScintillaGTKAccessible.cxx
> +++ b/gtk/ScintillaGTKAccessible.cxx
> @@ -1077,6 +1077,7 @@
> }
> g_once_init_leave(&registered, 1);
> }
> + // FIXME: we need to put a strong reference in *cache
> *cache = GTK_WIDGET_CLASS(widget_parent_class)->get_accessible(widget);
> #else // no public API, no factory, so guess from the parent and instantiate
> if (*cache == NULL) {
> @@ -1091,8 +1092,10 @@
> // object which would be created for the parent type of ScintillaObject.
> if (g_type_is_a(parent_atk_type, GTK_TYPE_ACCESSIBLE)) {
> *cache = scintilla_object_accessible_new(parent_atk_type, G_OBJECT(widget));
> + // FIXME: don't unref, we don't own the ref
> g_object_unref(parent_obj);
> } else {
> + // FIXME: we need to put a strong reference in *cache
> *cache = parent_obj;
> }
> }

However, my tests on GTK2 didn't show any issue, so I'm kind of
surprised, hence why I'd have to check further.

Regards,
Colomban

[Neil Hodgson]

Colomban Wendling:

> However, my tests on GTK2 didn't show any issue, so I'm kind of
> surprised, hence why I'd have to check further.

OK. I haven’t seen any crashes. There is quite a lot in the new release so, in the absence of a confirmed crash, I’d like to steam ahead. If a crash is found, there can be a 3.7.2 just to fix that.

Neil