skrf.vectorFitting.plot_* : mplt.figure() & mplt.show() : no bueno

42 views
Skip to first unread message

Ken Harris

unread,
Apr 17, 2021, 1:08:18 AMApr 17
to scikit-rf

The skrf.vectorFitting stuff is very cool (I did some measurements w/ a nanovna-v2 and used vectorFitting).

However ... it's better not to put mplt.figure() & mplt.show() calls in skrf.vectorFitting.plot_* calls.  Better to do like the other plot routines (eg : plot_s_smith) and allow an optional "ax" parameter.


vinc0110

unread,
May 24, 2021, 1:49:53 PMMay 24
to scikit-rf
Thanks for reporting this issue. The plotting routines were updated accordingly and the changes will be included in version 0.18, which should be released soon.

By the way: there have been two bugs in the vector fitting algorithm, causing it to converge rather poorly. These are also fixed in v0.18.

Ken Harris

unread,
May 24, 2021, 5:26:29 PMMay 24
to scikit-rf

Thanks !
Reply all
Reply to author
Forward
0 new messages