1.5 version 1

1 view
Skip to first unread message

BandonRandon

unread,
Jan 18, 2010, 2:11:32 AM1/18/10
to ScholarPress Dev
Hi,

I spend a few hours working on some improvements for the 1.5 release.
I don't know if I'll have more changes later but i did quite a bit so
i figured I'd upload this and get it to you as soon as possible.

New with this version:
* Clean up of some admin styles (resized gravatar images as well as
some basic hierarchy on options)
Do you know how to/do we want to create wpbook as it's own menu in
the wp sidebar we are getting a lot of options there.

*Added Pageing options as their own section

*Allow user to select pages to be excluded

* Added option to allow a menu of parent pages at top of the app below
the title, if all parent pages are exclude the next child page will be
shown (this think is a wp default thing)

*Fixed "Facebok" typeo in line line 182 of theme/index.php

* Option to turn on and off page list under content (independent of
menu)

* Option to turn on/off recent post under content

*Allow user to set the amount of recent post to show under content
(default 10)

*Cleaned up custom header/footer now only one function instead of two
(no reason to have two functions)

*Added %tag_links% and %category_links% to custom header footer as
well as made archive pages work. ( I added new filters
"fb_filter_catlink" and "fb_filter_taglink" but not sure if we can
just use the fb_filter_postlink function for all the rewriting which i
think should work.

TO DO:
* Translation
* Maybe get rid of tool tips or upgrade them to the new version of the
script
* minify the javascript file inside of admin_includes

Your thoughts or idea on this would be great.

BandonRandon

unread,
Jan 18, 2010, 2:17:06 AM1/18/10
to ScholarPress Dev
oh, also on the TODO for me would be to make an option to uninstall
the plugin (delete the wpbookadminoption field and deactivate the
plugin)

John Eckman

unread,
Jan 18, 2010, 9:49:46 AM1/18/10
to scholarp...@googlegroups.com
Thanks for these - I'm assuming you uploaded a file to the Google Group?

Assuming you've worked against 1.4.2 for these?

I definitely think that 1.5 needs to include the move to PHP5 and the publish to FB stream, so I will try to integrate your changes with mine.

> --
> You received this message because you are subscribed to the Google Groups "ScholarPress Dev" group.
> To post to this group, send email to scholarp...@googlegroups.com.
> To unsubscribe from this group, send email to scholarpress-d...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/scholarpress-dev?hl=en.
>
>


----------------------------------------
John Eckman
eckma...@gmail.com
http://www.johneckman.com/

John Eckman

unread,
Jan 18, 2010, 1:51:11 PM1/18/10
to scholarp...@googlegroups.com
I'm concerned about including the Dynamic Drive stuff in wpbook/theme/style.css

At this url: http://www.dynamicdrive.com/style/

I find a link to usage terms ( http://www.dynamicdrive.com/style/csslibrary/tos/ ) which say:

> Users may NOT, however, redistribute or repost/ resell for download any CSS code (including any graphics) found in the CSS library. Redistribution is defined as re-offering our codes for download in any fashion, whether on a competing web site, an application that generates code snippets, or a CD-ROM collection of CSS/JavaScript codes etc.

They say that this IS acceptable:

> As a software developer, use our CSS codes within a application/ program as part of its interface, such as a CSS menu being used as the program's navigation interface. The program itself can be distributable.

So I think as far as Dynamic Drive is concerned we may be ok.

The problem is that WPBook itself is distributed under GPL, as is WordPress. Can we include along with our GPL stuff code (even if it is just a dozen lines of CSS) that is under a more restrictive license?

BandonRandon

unread,
Jan 29, 2010, 3:11:30 AM1/29/10
to ScholarPress Dev
I sent an e-mail to Dynamic Drive and this was their response:
"Hi:
Your usage of the code qualifies as it being part of a larger program,
so you're fine. :)"

So apparently we CAN include that bit of code in the plugin.

On Jan 18, 10:51 am, John Eckman <eckman.j...@gmail.com> wrote:
> I'm concerned about including the Dynamic Drive stuff in wpbook/theme/style.css
>
> At this url:http://www.dynamicdrive.com/style/
>

> I find a link to usage terms (http://www.dynamicdrive.com/style/csslibrary/tos/) which say:

> eckman.j...@gmail.comhttp://www.johneckman.com/

John Eckman

unread,
Jan 29, 2010, 8:39:05 AM1/29/10
to scholarp...@googlegroups.com
From their perspective, we can.

I was more concerned about the GPL side, but I guess so long as they've given us permission to use it in what is clearly a GPL'd program, then they've consented to release that bit of code under GPL.

On Jan 29, 2010, at 2:11 AM, BandonRandon wrote:

> I sent an e-mail to Dynamic Drive and this was their response:
> "Hi:
> Your usage of the code qualifies as it being part of a larger program,
> so you're fine. :)"
>
> So apparently we CAN include that bit of code in the plugin.

BandonRandon

unread,
Jan 29, 2010, 7:28:09 PM1/29/10
to ScholarPress Dev
Yeah that's what I was worried about to so I made sure I mentioned GPL
in my message to them. I think they are more worried about people
claiming the work as there own (which GPL doesn't allow) and
redistubuting just the CSS part of the code as an indpendent product.
(which is technically allowed with GPL but it would be a pain in the
butt to just pull the CSS menu out of WPBook although it would be
done).

I think the main thing is give credit where credit is do and expect
people to be responsible with code.

Also, did you see that I got some code for the 1.5 version from
another GPL plugin that allows us to list all pages although i changed
the code I added credit in the main wpbook.php file.

> eckman.j...@gmail.comhttp://www.johneckman.com/

Reply all
Reply to author
Forward
0 new messages