scalapb json4s fails parsing numbers from string using the proto wrapper

Med Ch

unread,

Jun 13, 2019, 5:53:19 PM6/13/19

to ScalaPB

Hi,

For some reasons i need to use the wrapper for DoubleValue, StringValue https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/wrappers.proto

Using the java com.google.protobuf.util.JsonFormat I am still able to parse double and numbers from string but not using ScalaPB

I am using the latest scalapb-json4s 0.9.0

Thanks

Nadav Samet

unread,

Jun 14, 2019, 10:45:44 PM6/14/19

to Med Ch, ScalaPB

Hi Med, thanks for reporting. This has been fixed now in https://github.com/scalapb/scalapb-json4s/commit/2c8eaf1e2f53d3e015fa12eb94a2ac302c8ac4be. I ended up improving compatibility for all number types. We will have a version that includes this fix released soon.

--
You received this message because you are subscribed to the Google Groups "ScalaPB" group.
To unsubscribe from this group and stop receiving emails from it, send an email to scalapb+u...@googlegroups.com.
To post to this group, send email to sca...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/scalapb/c07f0c4b-063f-4655-bec7-80d04a2cdec1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

-Nadav

Med Ch

unread,

Jun 17, 2019, 10:24:30 AM6/17/19

to ScalaPB

Hi,

thanks for the quick answer, I am seeing that theses changes are not merged to 0.9.1 release, I guess it will be for the next one. When do you think this fix will be released?

Thanks,

--Med

On Friday, June 14, 2019 at 10:45:44 PM UTC-4, Nadav Samet wrote:

Hi Med, thanks for reporting. This has been fixed now in https://github.com/scalapb/scalapb-json4s/commit/2c8eaf1e2f53d3e015fa12eb94a2ac302c8ac4be. I ended up improving compatibility for all number types. We will have a version that includes this fix released soon.

On Thu, Jun 13, 2019 at 2:53 PM Med Ch <chabchoub...@gmail.com> wrote:

Hi,
For some reasons i need to use the wrapper for DoubleValue, StringValue https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/wrappers.proto

Using the java com.google.protobuf.util.JsonFormat I am still able to parse double and numbers from string but not using ScalaPB
I am using the latest scalapb-json4s 0.9.0

Thanks

--
You received this message because you are subscribed to the Google Groups "ScalaPB" group.

To unsubscribe from this group and stop receiving emails from it, send an email to sca...@googlegroups.com.

To post to this group, send email to sca...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/scalapb/c07f0c4b-063f-4655-bec7-80d04a2cdec1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
-Nadav

Nadav Samet

unread,

Jun 17, 2019, 10:49:39 AM6/17/19

to Med Ch, ScalaPB

I've just released 0.9.2 with this fix. It will appear on maven central shortly.

To unsubscribe from this group and stop receiving emails from it, send an email to scalapb+u...@googlegroups.com.

To post to this group, send email to sca...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/scalapb/6c9b8965-2f4f-4fde-9aec-ab0cb1fe4370%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

-Nadav

Med Ch

unread,

Jun 17, 2019, 1:38:26 PM6/17/19

to ScalaPB

thanks again, it's working now :)

--Med

On Monday, June 17, 2019 at 10:49:39 AM UTC-4, Nadav Samet wrote:

I've just released 0.9.2 with this fix. It will appear on maven central shortly.

To view this discussion on the web visit https://groups.google.com/d/msgid/scalapb/6c9b8965-2f4f-4fde-9aec-ab0cb1fe4370%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
-Nadav

Reply all

Reply to author

Forward