On Saturday, March 23, 2013 1:53:14 AM UTC+9, John Sullivan wrote:
Hi, and welcome!
I was playing around with forking
the project and going through the build and test cycle, and I came up
with fixes for a couple of trivial bugs:
SI-6654 return of filterKeys is not serializable 
SI-7005 Map#mapValues is not serializable 
can make a pull request for these at any time. If you want to preview
see . I know these issues are both related to SI-4776 ,
but I don't see any harm in putting in these trivial fixes first.
Sounds quite sensible.
Don't let silence stop you - if nobody answers, we might very well want your fix. So do send a pull request.
Don't forget to name a reviewer and to remind him - I'd suggest @axel22 (for collections) and @rkuhn, since he argued for fixing SI-4776 instead, so maybe he figured this is a bad idea and can explain why - but I guess not.
I think you should target master because your change doesn't seem *forward* binary compatible (see previous discussions on this mailing list): you make some protected classes newly extend Serializable.
for not discussing this on the internals mailing list first. It was
really just an exercise to learn the build a bit.
I'm just a young contributor, but I observe that minor pull requests are not discussed on scala-internals, while it happens mostly for more controversial changes.
Also, you are not required to discuss changes *before* doing them. So nothing to apologize, and please keep on hacking! Wanna try SI-4776?