Are there known failures in test_replays/test_all.py?

9 views
Skip to first unread message

Uncle Vinny

unread,
Jan 24, 2018, 2:24:36 AM1/24/18
to sc2reader
I just forked from https://github.com/ggtracker/sc2reader (the upstream branch) and ran test_all.py

This generates a ton of logs, much of which looks like errors, such as:

Whoa! 'CreepTracker' object has no attribute 'creepTracker'
...
Unable to change type of None [4C80001] to SpecialNexus [frame 8345]; unit type not found in build base
...
Conflicting results for Team 1: {'Loss', 'Win', None}
...
Bad upkeep_pid (4) for event <class 'sc2reader.events.tracker.UnitBornEvent'> at 00.00 [0].

....etc.... and at the end there are 4 tracebacks and a status message:

======================================================================
ERROR: test_33_shift_click_calldown_mule (__main__.TestReplays)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_replays/test_all.py", line 512, in test_33_shift_click_calldown_mule
    self.assertEqual(len(filter(efilter, replay.events)), 29)
TypeError: object of type 'filter' has no len()

======================================================================
ERROR: test_33_shift_click_spawn_larva (__main__.TestReplays)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_replays/test_all.py", line 518, in test_33_shift_click_spawn_larva
    self.assertEqual(len(filter(efilter, replay.events)), 23)
TypeError: object of type 'filter' has no len()

======================================================================
ERROR: test_creepTracker (__main__.TestReplays)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_replays/test_all.py", line 387, in test_creepTracker
    assert replay.player[player_id].max_creep_spread[1] >0
AttributeError: 'Participant' object has no attribute 'max_creep_spread'

======================================================================
ERROR: test_lotv_creepTracker (__main__.TestReplays)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_replays/test_all.py", line 434, in test_lotv_creepTracker
    assert replay.player[player_id].max_creep_spread >0
AttributeError: 'Participant' object has no attribute 'max_creep_spread'

----------------------------------------------------------------------
Ran 60 tests in 30.223s

FAILED (errors=4, expected failures=3)

Is this to be expected, or should I open an issue on the failing test(s)? 

David Joerg

unread,
Jan 24, 2018, 6:21:16 AM1/24/18
to sc2reader
This is not expected.  I did a clean checkout just now and I am not able to reproduce the errors that you encountered.

Opening an issue would be good so that when someone fixes the issue you've encountered, we have a record of how it was solved.

I'm not working actively on sc2reader and I'm not sure if anyone is so the issue might just sit there.

My guess is that those errors are related to some kind of configuration or setup issue.  The 'CreepTracker' object has no attribute 'creepTracker' message seems especially pertinent.    —David





--
You received this message because you are subscribed to the Google Groups "sc2reader" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sc2reader+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Uncle Vinny

unread,
Jan 24, 2018, 3:21:02 PM1/24/18
to sc2reader
Ok, the bug is logged now: https://github.com/ggtracker/sc2reader/issues/43

Today I'm going to try to run a few tests individually to see if I can narrow down what's happening.

Thanks!
To unsubscribe from this group and stop receiving emails from it, send an email to sc2reader+...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages