Thoroughly Tested

5 views
Skip to first unread message

Graylin Kim

unread,
May 20, 2011, 12:46:10 AM5/20/11
to sc2rea...@googlegroups.com
Today I ran sc2reader against between 500-600 replays.

Surprisingly, I found only a couple bugs in the parsing. I've since fixed them and pushed the code (closed an issue too!). We still can't be 100% sure that parsing is correct for all versions of Starcraft II, but its become increasingly more likely.

Now its time to focus on figuring out what all the bytes mean!

~Graylin

Dominic Baranski

unread,
May 20, 2011, 4:18:07 PM5/20/11
to sc2rea...@googlegroups.com
did you take any benchmarks for speed comparisons?

Dom

Graylin Kim

unread,
May 20, 2011, 4:39:36 PM5/20/11
to sc2rea...@googlegroups.com
Oh, no. I didn't benchmark anything. 

Would you be interested in doing that? In the past we've used the cProfile package with great success. It'd be good to have a script for benchmarking that we can run periodically to see how we are doing.

~Graylin
Reply all
Reply to author
Forward
0 new messages