Patch 1.40

9 views
Skip to first unread message

ZsoL

unread,
Sep 18, 2011, 5:03:56 AM9/18/11
to sc2rea...@googlegroups.com
Hi Guys,

Looks like 1.40 will change the replay format yet again... See my email about it here: https://groups.google.com/d/topic/phpsc2replay/kwYrxizNcCg/discussion

Zsol

Graylin Kim

unread,
Sep 18, 2011, 9:23:37 AM9/18/11
to sc2rea...@googlegroups.com
Can you (anyone) submit more 1.4.0 replay files?

I've patched SC2Reader to read this one file but I'm sure it doesn't cover all the edge cases 1.4.0 might introduce. See my patch and let me know.

~Graylin

ZsoL

unread,
Sep 18, 2011, 1:30:54 PM9/18/11
to sc2rea...@googlegroups.com
Here's one more I just played. Gotta run, but will try to squeeze in a few games during next week

Is your change backward compatible?
Backwater Gulch.SC2Replay

Graylin Kim

unread,
Sep 18, 2011, 3:38:38 PM9/18/11
to sc2rea...@googlegroups.com
Thanks for the replay, I'll take a look. The change does not appear to be backwards compatible. I was just too lazy in the commit to make a new ability parser for the new version because I'm just throwing that code away.

When the patch comes out and I can definitively say what the changes are I'll do it right on the master branch.

Graylin Kim

unread,
Sep 18, 2011, 5:17:15 PM9/18/11
to sc2rea...@googlegroups.com
This second file also appears to parse fine with those minimal changes.

I wish I could make more sense of why those two particular ability events needed an extra byte, but we haven't got that far into the details of parsing yet.

~Graylin

Graylin Kim

unread,
Sep 21, 2011, 3:14:20 PM9/21/11
to sc2rea...@googlegroups.com
I've added 1.4.0 support "officially". The new version adds an extra byte of data a certain subset of player ability action events.

Its tested against about 30-40 random replay files and appears to be functioning.

Zsol

unread,
Sep 21, 2011, 3:19:14 PM9/21/11
to sc2rea...@googlegroups.com
Great work, it never actually occured to me that it's only one extra byte.
Thanks! :)
Reply all
Reply to author
Forward
0 new messages