Git Config: Names in Commit

5 views
Skip to first unread message

Zieris, Franz

unread,
Aug 29, 2018, 7:52:55 AM8/29/18
to saros...@googlegroups.com
Hello everyone,

it's not a big issue, but please make sure to configure your Git clients properly [1].

> Make sure that both "Author" and "Committer" conform to the format:
>
> John Doe <john...@anywhere.com>
>
> The following formats are not allowed:
> "johnd <john.doe@...>" or "johnny <john.doe@...>" or "John <john.doe@...>"

About ten recent commits from different authors have the "johnny", "John" or "JohnDoe" (no space) format.

Cheers,
Franz

[1] http://www.saros-project.org/coderules/before-committing

Tobias Bouschen

unread,
Aug 29, 2018, 8:10:34 AM8/29/18
to saros...@googlegroups.com
This does not seem to be a problem with the git clients but with rather
with GitHub. When squashing PRs, GitHub seems to use the username as the
author (if no real name is given?).

For example, the PR I just squashed and merged created a commit by the
author "tobous" (my GitHub user name). But on my local branch, the
author is set correctly.

The problem is probably that I did not have my real name set up in my
GitHub profile. I will have to try it out now that my name is set.

Best regards,
Tobias

Tobias Bouschen

unread,
Aug 29, 2018, 8:18:07 AM8/29/18
to saros...@googlegroups.com
As a short update: Setting the correct name works. Once the real name is
set up in the GitHub profile ("Public Profile" > "Name"), it is used
when creating squashed commits during PR merges instead of the GitHub
username/handle.
Reply all
Reply to author
Forward
0 new messages