Reviewers needed for: [FEAT][I] Customizable user highlight colors #482

9 views
Skip to first unread message

flashma...@gmail.com

unread,
Mar 22, 2019, 3:52:49 PM3/22/19
to Saros Development
Hi there 👋

I've just opened my first PR for contributing to Saros: https://github.com/saros-project/saros/pull/482

I've stumbled across Saros yesterday, and was able to set it up and demo it really fast. I noticed that colors are a bit off on my dark IntelliJ IDE, so I fixed it up.

I'd like to ask for reviews on my PR. Also, how does this work in general? Am I supposed to ask in this mailing list, or is there some other, better suited channel for asking for reviews?

David

Tobias Bouschen

unread,
Mar 22, 2019, 4:03:48 PM3/22/19
to saros...@googlegroups.com
Hi David,

Thanks for your contribution. We don't have a set policy for this yet as
we are still in the process of moving from a mostly university-driven
project (developed by students) to being completely open source (and
mainly working through independent developers).

In general, I would advise to ask on our Gitter page
(https://gitter.im/saros-project/saros) as it allows for a more direct
form of communication. But on the mailing list is fine as well.

But you bring up a good point. We will discuss how this should be
handled and create a guide on the GitHub page on how to contribute
correctly.

As towards your specific review request: I have already added myself as
a reviewer and will look at the code in the next couple of days.

Best regards,
Tobias

da...@pspdfkit.com

unread,
Mar 24, 2019, 2:31:29 PM3/24/19
to Saros Development
Thanks Tobias for letting me know. It's great to see that there are plans to push forward Saros via an open source initiative, and I'd be happy to contribute to this as much as I can.

David
Reply all
Reply to author
Forward
0 new messages