Re: Process definition changes/GraphLoader
Paul Lorenz
I applied your patch and merged it.
The patch didn't apply cleanly. It wouldn't merge
ProcessDefinitionResolver.java. I recreated it, but I was hoping you
could add the javadoc back to it.
Aside from that I removed an unused JAXBException from a throws clause
and cleaned up some of the headers.
As far as copyright headers goes, I'm just trying to get the to
reflect reality. Anything you wrote, you own the copyright to, unless
you fill out copyright reassignment paperwork. So I just try to keep
it straight in the headers who has touched what and when :) So if I
haven't touched the file, my name doesn't need to be there.
What are your plans for alternate input format(s)?
cheers,
Paul
On Wed, Jul 1, 2009 at 3:48 AM, Vincent Kirsch<vincent...@gmail.com> wrote:
> Hi Paul, Since I got fed up to always have to perform the same SVN merges
> every time I update the Sarasvati sources :-), I created a patch with the
> modifications I made to the GraphLoader and other classes/interfaces in
> order to allow Sarasvati to load process definitions from sources other that
> an XML file. I decided to create a patch because I had to change a couple of
> things in the editor part (GraphEditor etc.) and I noticed you're kind of
> busy in there at the moment, so with a patch you can continue to work
> without too much hassle;besides, that way you can check if the changes are
> OK. If so, you can either apply the patch or let me do the commit, it
> doesn't matter to me.
> If you think a patch is not a good idea, I can still do a commit whenever
> you're ready, or commit on a branch as already discussed. In all cases, I
> attached the patch to this mail.
> Just one thing you'll need to check though: I added some classes and
> interfaces; I put the header (this is part of Sarasvati etc). I wasn't sure
> what I should do with the copyright statement, so I put Copyright 2009 Paul
> Lorenz/Vincent Kirsch. For me it doesn't really matter, I mean it's ok for
> me if my name doesn't appear there (it's your product after all :), but I
> thought I'd just tell you about this. Cheers! Vincent
Paul Lorenz
alternate input formats will be nice, especially for those who are XML
averse :)
cheers,
Paul