Salt requiring reverse DNS records?

[ckm]

In my attempt to debug a syndic problem, I've run into other issues

Specifically, salt-syndic is now returning:

[salt.utils     ][ERROR   ] This master address: salt was previously resolvable but now fails to resolve! The previously resolved ip addr will continue to be used

Because everything in the configs is specified as an IP address, it's a bit of a strange error, and suggests a reverse lookup (why?) which doesn't exist for this host.

Some of the offending code seems to be here...

https://github.com/dcolish/salt/commit/599026db7d2325e56270f2e156a7fadb283569c5

Why does salt do reverse lookups then fail if they don't exist?  This seems to be new behavior as I didn't have this issue when I first install everything about 2 months ago...

Thx.

Chris.

[Dan Colish]

I cannot comment to the choice that bad DNS could cause a failure, but that commit is not quite right. That was only a move of the code. The original commit is 88c2983de22be00e94c0203cd981c3454853ba40.

-- Dan

[Thomas S Hatch]

try:

     socket.inet_aton(addr)

except socket.error:

If the ip address is correctly specified then it never gets tot he actual DNS check. Salt does not require DNS and in NO WAY requires reverse DNS