Salt 2015.8.(2|3) Released ? Release process & debian packages

[Arthur Lutz]

Hi list,

While tracking a bug found on 2015.8.1 I found that 2015.8.2 and
2015.8.3 had release notes
https://docs.saltstack.com/en/latest/topics/releases/. These two
releases don't seem to have been announced on salt-users.

Looking at http://repo.saltstack.com/ it seems that the latest package
is 2015.8.1.

I know this is a recurring question but could the release process be
explicitly documented (at the top of
https://docs.saltstack.com/en/latest/topics/releases/ for example). It's
something like - tag added to git, release notes published, pypi upload,
maintainers notified, packages built for X/Y, announce on salt-user,
tweet, etc. (having some estimated times for each step would be nice).

Arthur

--
Arthur Lutz - Logilab
http://www.logilab.fr/
Twitter @arthurlutz https://twitter.com/arthurlutz
@logilab https://twitter.com/logilab

[mwood...@saltstack.com]

Hi Arthur,

We actually recently posted our release checklist here: https://github.com/saltstack/salt/wiki/Release-Checklist

We're working to nail it down a bit more so our releases can be more predictable by the community. For now we try for a 2-day lead time between when we post to pypi/announce to packagers and the actual release.

As far as the 2015.8.2/3 confusion, we found a significant orchestration issue after we had publicly tagged 2015.8.2 so we had to change the release version. We added a note about this at the top of the 2015.8.2 release notes to try and avoid confusion--maybe we need to make it more clear :)

- Meggie

[mwood...@saltstack.com]

2015.8.3 is live now: https://docs.saltstack.com/en/latest/topics/releases/2015.8.3.html

On Tuesday, December 1, 2015 at 5:56:55 AM UTC-7, Arthur Lutz wrote:

[David Douard]

But the provided salt-minion debian package (on http://repo.saltstack.com/apt/debian/8/amd64/2015.8/ )
still don't have a correct systemd service file (missing the KillMode flag,
see https://github.com/saltstack/salt/issues/29295) ...

According to what I read in the debian packaging code in https://anonscm.debian.org/git/pkg-salt/salt.git
salt-minion 2015.8.3 should be supplied with a correct service file.

How is it possible?

David

--
You received this message because you are subscribed to the Google Groups "Salt-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to salt-users+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[mwood...@saltstack.com]

Hi David,

The PR to fix the systemd service file was merged after we tagged the 2015.8.3 release. It will be included in the next releases--2015.5.9 and 2015.8.4--in January.

[David Douard]

Hi,

I don't understand, which PR are you referring to?

Because on the one hand, the $SALTSRC/pkg/salt-minion.service file in 2015.8.3 is correctly setting the KillMode flag.
On the other hand, the 2015.8.3+ds-1 version of the debian packaging provided by Benjamin Drung includes the
changeset 2d24824b (Use upstream systemd service files,
http://anonscm.debian.org/cgit/pkg-salt/salt.git/commit/?id=2d24824b8a4807aed537c403c15ad8651606b89c )
which make the debian package use the $SALTSRC/pkg/salt-minion.service file.

So there is no required PR in upstream salt source code to produce a correct salt-minion debian package.

What am I missing here?

David

 

[basepi]

I think Meggie was referring to your pull request: https://github.com/saltstack/salt/pull/29296

It came in too late for the release.

KillMode is set correctly for minion but not master. Did the salt-minion.service file not make it into the packages? Because the minion one was fixed prior to the release of v2015.8.3.

--

Colton Myers

Core Engineer, SaltStack

@basepi on Twitter/Github/IRC

Registration for SaltConf 2016 is open! http://saltconf.com/register/

To unsubscribe from this group and stop receiving emails from it, send an email to salt-users+unsubscribe@googlegroups.com.

[David Douard]

On Thu, Dec 10, 2015 at 7:36 PM, basepi <colton...@gmail.com> wrote:

I think Meggie was referring to your pull request: https://github.com/saltstack/salt/pull/29296

But this PR concerns old versions only since the debian packaging has been removed from the upstream source code by Joe Healy at revision d4a41a7d6a6d87d89a3843be0d859bd2a1031abd.

So I don't understand how is the debian package provided by saltstack built. I though it is built using the packaging work made by Debian (by Benjamin Drung), but I'm not sure and I don't know (and there is no way to know for sure) which packaging code is used for that.

David