count number of commas in a variable

[brad.v...@gmail.com]

I'm not sure of the syntax of the jinja length filter.  I'm setting a variable to all of the installed kernel packages.  I want to check if there are more than two.  The variable is a comma separated list of the installed kernels.  I want to check of there are more than 'x' commas in that list.  Maybe length isn't the correct filter?

```{% set KERN = salt.pkg.version('kernel') %}

{% if KERN|length > 2 %}```

I know that is not correct.  It is just counting the number of characters.  Any suggestions?

[Aaron Greengrass]

A suggestion, use something like 

{% KERNLIST = kern.split(',') %}

{% if KERNlist|length > 2 %}

That should convert your string into a list of strings, and length should then return the number of list items.

------ Original Message ------

From "brad.v...@gmail.com" <brad.v...@gmail.com>

To "Salt-users" <salt-...@googlegroups.com>

Date 11/30/2022 6:45:10 AM

Subject [salt-users] count number of commas in a variable

--
You received this message because you are subscribed to the Google Groups "Salt-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to salt-users+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/salt-users/22846b5b-9fad-4b72-acce-17c86025cd76n%40googlegroups.com.

[brad.v...@gmail.com]

That has it:

{% set KERNLIST = KERN.split(',') %}

{% if KERNLIST|length > 2 %}

that works!   Thanks!

[Phipps, Thomas]

so, not to nit pick but if you are just trying to count the commas splitting on comma means your length count will be one higher. you should -1 the length.

To view this discussion on the web visit https://groups.google.com/d/msgid/salt-users/emcd899d20-9784-4564-bc25-b301478a9724%4014bdff09.com.

[brad.v...@gmail.com]

You are correct.  I changed the length to > 1.  We just want two kernels installed.  :)

[brad.v...@gmail.com]

Problem now is that all of the jinja is rendered before any salt stanzas are run.  I have:

{% if grains['manufacturer'].startswith('HP') %}

{% set KERN = salt.pkg.version('kernel') %}

{% set KERNLIST = KERN.split(',') %}

{% if KERNLIST|length > 1 %}

remove_older_kernel_versions:

  cmd.run:

    - name: /bin/package-cleanup -y --oldkernels --count=2

{% set KERN = salt.pkg.version('kernel') %}

{% endif %}

{% set DEVEL = salt.pkg.version('kernel-devel') %}

{% if grains['num_gpus'] > 1 %}

{% if KERN == DEVEL %}

print-kernel-info:

  cmd.run:

    - name: echo "kernel = {{ KERN }} - kernel-devel = {{ DEVEL }}"

{% else %}

{% set KERNLIST = KERN.split(',') %}

{% if DEVEL == KERNLIST[0] %}

kernel-devel2:

  pkg.installed:

    - name: kernel-devel

    - version: {{ KERNLIST[0] }}

{% endif %}

{% endif %}

{% else %}

{% if DEVEL is defined %}

{% if DEVEL|length %}

remove-devel-kernel:

  pkg.removed:

    - name: kernel-devel

{% endif %}

{% endif %}

{% endif %}

{% endif %}

I want the KERN variable reset after the extra kernels are removed and the DEVEL likewise.  They are all getting set before any salt stanzas are run.  I'm thinking about removing the package-cleanup section to a separate salt state and then just adding some code before this section to make sure it is run before this state?  Does that sound like the correct approach?

[Phipps, Thomas]

i mean the best solution is to set installonly_limit to the number of kernels to keep depending on the machine kind in /etc/yum.conf and let yum do its job.

To view this discussion on the web visit https://groups.google.com/d/msgid/salt-users/df5480c0-fb7c-4e7a-82de-4f552f72c170n%40googlegroups.com.

[Brad Van Orden]

I do have that, but I need to:

1.  Remove all kernels beyond two on the hardware servers.

2.  Remove the kernel-devels from all hardware servers without Nvidia GPUs.

So, I want to test and see if this server has more than two kernel versions.  If so, reduce that.  Then, check if this server has Nvidia GPUs.  If so, check and see if both devel versions of the kernel are installed to match the two installed kernel versions.  If not a GPU server, remove any kernel-devel packages.

Regards,

Brad

You received this message because you are subscribed to a topic in the Google Groups "Salt-users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/salt-users/OMu2FsF3xjc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to salt-users+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/salt-users/CAPaX09hD-jYjSEEX%3D%3DnJis0r_fTOswR-OfmX%3DNmy8K6oPVdgrA%40mail.gmail.com.

[Phipps, Thomas]

n it sounds like you need to get into orchestration. it is commonly used to get around the strict ordering of the render engines.

To view this discussion on the web visit https://groups.google.com/d/msgid/salt-users/CAEAkesyrG0bkeRmWdQFZ6M3swk3Ee2H_je9r%2BCyg53mGGJrCXQ%40mail.gmail.com.

[brad.v...@gmail.com]

orchestration sounds interesting, but involves purchasing a package which will not happen just to satisfy this one problem.  I removed limiting the number of kernels out of this state.  I created a one time state to check the number of installed kernels and run the package cleanup application if needed.  My problem right now is trying to determine if the servers with a GPU have the kernel-devel versions installed to correspond to the installed kernel versions.  I attempted:

{% set KERN = salt.pkg.version('kernel') %}

{% set DEVEL = salt.pkg.version('kernel-devel') %}

{% if KERN == DEVEL %}

assuming that the comma separated lists would appear in the same order.  They don't.  One one server I got:

KERN = '3.10.0-1160.66.1.el7,3.10.0-1160.71.1.el7'

DEVEL-' 3.10.0-1160.71.1.el7, 3.10.0-1160.66.1.el7'

which really are equivalent but not strictly equal.  I tried sending to sort, but it sorted each by every single character.  :)  Not exactly what I wanted.  I guess I'll have to split on the commas and then see if each part appears in the other string?  Let me give that a try.

[brad.v...@gmail.com]

I got around this with:

{% set KERN = salt.pkg.version('kernel') %}

{% set DEVEL = salt.pkg.version('kernel-devel') %}

{% set KERNLIST = KERN.split(',') %}

{% if KERNLIST[0] not in DEVEL %}

{# KERNLIST[0]-devel not installed #}

{% endif %}

{% if KERNLIST[1] not in DEVEL %}

{# KERNLIST[1]-devel not installed #}

{% endif %}

and that is working.  Thanks for the help folks!

[Phipps, Thomas]

I'm not sure where you heard you need to purchase something to use orchestration in salt. but that is completely untrue. the only part of salt that costs money is the enterprise gui interface. and professional support.

https://docs.saltproject.io/en/latest/topics/orchestrate/orchestrate_runner.html#the-orchestrate-runner

To view this discussion on the web visit https://groups.google.com/d/msgid/salt-users/61fa0cce-21c6-40d3-a21d-657259825eb4n%40googlegroups.com.

[Brad Van Orden]

Just someone I work with said it would cost money.  I'll look into it in more detail.

Thanks!

To view this discussion on the web visit https://groups.google.com/d/msgid/salt-users/CAPaX09jcyOocYHUYnDKhfP07nStcX7QCr1-ZY%2BCSxsPzaBC71g%40mail.gmail.com.