Use service.reload instead of service.restart

[Sebastian]

Hi,

I found this line https://github.com/saltstack/salt/blob/develop/salt/states/service.py#L367 in the source code of Salt, but don’t know how to use it in my Apache2 state file. The watcher should reload Apache2 instead of restarting it when someone changes the config files. Any idea?

Here is my state file:

apache2:

  pkg:

    - latest

  service:

    - running

    - watch:

      - file: /etc/apache2/apache2.conf

      - file: /etc/apache2/httpd.conf

    - require:

      - pkg: apache2 

[Thomas S Hatch]

Arguments in sls files get passed into the mod_watch function if the mod_watch function accepts them:

apache2:

  pkg:

    - latest

  service:

    - running

    - reload: True

    - watch:

      - file: /etc/apache2/apache2.conf

      - file: /etc/apache2/httpd.conf

    - require:

      - pkg: apache2 

[Avi Marcus]

... so this needs to be doc'd somewhere?

And I believe not all systems support the reload arg?

-Avi

[Thomas S Hatch]

Correct, only if the system has a reload function in the relative service module, and yes, this needs to be documented.

[Jeroen Dekkers]

Wouldn't it be better if reload was the default? If you change a
config file, you almost always want to reload the daemon instead of
restarting it.

At Wed, 8 Aug 2012 09:45:37 -0600,

[Avi Marcus]

Not all init scripts and/or the actual software support hot-reloading.

-Avi

[Jeroen Dekkers]

At Wed, 8 Aug 2012 22:07:54 +0300,

Avi Marcus wrote:
> Not all init scripts and/or the actual software support hot-reloading.

You're right, we should use force-reload (at least on Linux):

http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

It will reload the service if that is supported and restart
otherwise. I guess that is precisely what we want.


Kind regards,

Jeroen Dekkers

[Avi Marcus]

Oh cool, monit's init.d has force-reload, even though it doesn't have reload.

-Avi

[Thomas S Hatch]

I would love to use fore-reload, but the underlying init scripts and init system will need to use it, and this is not always the case