error message from grep

[brad.v...@gmail.com]

We have a stanza:

{% if salt['cmd.run']('grep swap /etc/fstab') %}

swapoff_fstab:

  cmd.run:

    - name: sed -i.bak '/b\bswap\b/d' /etc/fstab

    - onlyif: grep -q '\bswap\b' /etc/fstab

every time it runs on a server where this has already successfully run, we get:

[ERROR   ] Command 'grep' failed with return code: 1

[ERROR   ] retcode: 1

[ERROR   ] Command 'grep' failed with return code: 1

[ERROR   ] output:

How do I restate it to get rid of the error messages?

[James Pearson]

Those messages are coming from the {% if salt['cmd.run']('grep swap
/etc/fstab') %} line

However, you don't need this check as you are also using 'onlyif' in
the stanza - which is also checking if that string appears in
/etc/fstab ?

It might be better to use something like 'file.line' to remove the
'swap' line - i.e. something like:

swapoff_fstab:
file.line:
- name: /etc/fstab
- match: '\bswap\b'
- mode: delete
- backup: True

It is also probably possible to use 'file.replace' to do something similar ?

James Pearson

[brad.v...@gmail.com]

That makes sense.  Will give it a try.  That was one of my first attempts in salt.  So, not very "salty."  :)