Docker version with plugins baked in?

121 views
Skip to first unread message

Pepe Silvia

unread,
Dec 3, 2015, 12:40:43 PM12/3/15
to sal-discuss
Greetings Graham!

Any chance we can get a Docker version with plugins included?  I'm thinking the ones on https://github.com/salopensource/grahamgilbert-plugins, included in the image?
After all, Docker is about portability, and I'm sure everyone prefers MOAR information when it comes to reporting...

Thanks for the consideration,
Pepe

Graham Gilbert

unread,
Dec 3, 2015, 3:25:54 PM12/3/15
to sal-d...@googlegroups.com, sal-discuss
The plugins in that repo don't work without additional facts or conditions installed on the client. I'm going to keep the docker image so it works with just factor, Munki and the sal scripts. Adding plugins to the image is pretty trivial anyway (-v /somewhere/plugins:/home/docker/sal/plugins). 

Graham Gilbert


--
You received this message because you are subscribed to the Google Groups "sal-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sal-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Pepe Silvia

unread,
Dec 10, 2015, 4:28:15 PM12/10/15
to sal-discuss
Hardly trivial if you ask me:

I have cloned the plugins as grahamgilbert:

$ cd /usr/local/sal_env/sal/plugins
$ git clone https://github.com/salopensource/grahamgilbert-plugins.git grahamgilbert


I start the container as:
docker run -d --name="sal" -p 80:8000 --link postgres-sal:db -e ADMIN_PASS=pass -e DB_NAME=sal -e DB_USER=admin -e DB_PASS=password -v /usr/local/sal_env/sal/plugins:/home/docker/sal/plugins macadmins/sal

What am I doing wrong, container starts, yet the plugins do not show.  I know the client is configured correctly, as the same client reports the plugin data correctly to a standalone Sal instance, just not Dockerized?

Graham Gilbert

unread,
Dec 11, 2015, 2:27:36 AM12/11/15
to sal-discuss
Your docker run command looks fine. Did you enable them in the settings page?

Pepe Silvia

unread,
Dec 11, 2015, 9:43:30 AM12/11/15
to sal-discuss
Snap!

That was it, you da man!

Pepe Silvia

unread,
Dec 11, 2015, 11:47:47 AM12/11/15
to sal-discuss
Just a sidenote, it seems Daniel Hazelbaker's plugins have not been converted for use with the new version of Sal...the minute I attempt to enable any of the plugins from https://github.com/salopensource/cabal95-plugins nginx craps out with 502 Bad Gateway...

Graham Gilbert

unread,
Dec 11, 2015, 11:49:07 AM12/11/15
to sal-discuss
Man that sucks. Can you raise an issue on that repo? I'll try and fix them when I can, but Daniel might not be on this list.
On Fri, 11 Dec 2015 at 16:47, Pepe Silvia <pstoj...@gmail.com> wrote:
Just a sidenote, it seems Daniel Hazelbaker's plugins have not been converted for use with the new version of Sal...the minute I attempt to enable any of the plugins from https://github.com/salopensource/cabal95-plugins nginx craps out with 502 Bad Gateway...

--

Pepe Silvia

unread,
Jan 28, 2016, 1:18:59 PM1/28/16
to sal-discuss
Graham, any chance you could find the time to convert the cabal-95 plugins to the new Sal format?  I've raised the issue over a month ago, and it does not look like Daniel is still maintaining the repo...  

Graham Gilbert

unread,
Jan 28, 2016, 1:21:12 PM1/28/16
to sal-discuss
It is unlikely I will for the next few months as I am going through a busy time personally. I would be happy to give commit access to anyone who wants to take the repo on through. 

Sent from my iPhone

Pepe Silvia

unread,
Jan 28, 2016, 1:56:08 PM1/28/16
to sal-discuss
fair enough...  are there any instructions out there on how to convert to new format, I could take a crack at it?

Graham Gilbert

unread,
Jan 28, 2016, 1:59:07 PM1/28/16
to sal-d...@googlegroups.com
Not yet, but they're basically the same. Just need to update the html mostly. 

Sent from my iPhone

Pepe Silvia

unread,
May 20, 2016, 3:22:06 PM5/20/16
to sal-discuss
bump

(we would like to update to current Sal but find the cabal-95 plugins indispensable)

Graham Gilbert

unread,
May 21, 2016, 4:45:26 AM5/21/16
to sal-d...@googlegroups.com
You could help me out by Trying to update them yourself? It's not particularly difficult. I don't use them, so they are unlikely to find their way onto my schedule. 

Sent from my iPhone

Pepe Silvia

unread,
May 24, 2016, 8:26:15 AM5/24/16
to sal-discuss
I would love to have a crack at it! 

I found the instructions for creating old-style plugins http://grahamgilbert.com/blog/2014/01/26/writing-plugins-for-sal-part-1/, but am missing the piece on how to convert these outdated plugins to the new format.  Is there any documentation available on that?

Graham Gilbert

unread,
May 24, 2016, 8:27:28 AM5/24/16
to sal-discuss
Reply all
Reply to author
Forward
0 new messages