No doctests are executed in sage/modular/pollack_stevens/padic_lseries.py

[Jens-Erik Riedel]

When running "sage -t" on the file sage/modular/pollack_stevens/padic_lseries.py no doctests are executed although the file contains quite a lot of doctests.

I think the reason for that is a typo in the very first line of the file:

  # sage.doctest: needs sage.ring.padics

It must be "rings" instead of "ring.

This is in Sage 10.3 as well as in Sage 10.4.beta9.

There is another typo in line 177 of that file: In the doctest comment a comma is missing between "indirect doctest" and "long time".

After having corrected these two typos all doctests in sage/modular/pollack_stevens/padic_lseries.py are successfully executed.

[julian...@gmail.com]

Would you mind creating a Pull Request with these changes at https://github.com/sagemath/sage?

julian

[Jens-Erik Riedel]

Thanks to a hint by Dima I found the same typo in two other files.
In sage/structure/factory.pyx line 523 it prevents a doctest from being run.

In sage/rings/polynomial/padics/polynomial_padic.py line 277 it is merely cosmetic.

I will create a Pull Request with fixes for all three occurrences of this typo.

[Vincent Delecroix]

Generalizing the problem of the OP : it is a severe issue that a tag
can completely prevent a file from being tested.

> --
> You received this message because you are subscribed to the Google Groups "sage-support" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-support...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-support/9767d29d-889a-4906-abde-53c4d6340cddn%40googlegroups.com.

[Jens-Erik Riedel]

I have created a pull request for this issue.

[Matthias Koeppe]

I agree, the problem is that currently we cannot distinguish typo'd doctest tags from valid doctest tags that are not present.

Part of the solution: https://github.com/sagemath/sage/issues/35856