Fwd: [sage-devel] Return "type" of the `logarithmic_embedding` function

Skip to first unread message

John Cremona

Jul 27, 2022, 2:14:30 PM7/27/22
to sage-nt

---------- Forwarded message ---------
From: Jing Guo <dev....@gmail.com>
Date: Wed, 27 Jul 2022, 10:49
Subject: [sage-devel] Return "type" of the `logarithmic_embedding` function
To: sage-devel <sage-...@googlegroups.com>


I am implementing the `logarithmic_embedding` function [0] (based on Krumm's code) for my GSoC project, which is used for implementing `points_of_bounded_height` function [1].

However, we encounter the following problem:

By definition (Def. 4.9.6, on page 208 of "A course in computational algebraic number theory"), the logarithmic embedding is a map from number field K to R^n. We are not sure how this function should return, and we consider two options:

1. The function returns a function closure, see examples in [2]

2. It returns a morphism, which is more mathematically correct:

V = VectorSpace(RR, 1)
K = CyclotomicField(3)
B = Hom(K, V, category=Sets())
phi = B(log_map)

Which one do you think is better from math and software engineering perspectives? Are there any other approaches that would be better for this case?

Thank you.


You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/ace5d6d9-22d3-4adf-9cc0-654bbc72c915n%40googlegroups.com.
Reply all
Reply to author
0 new messages