Tiny typo in GammaH subgroup docs

[David Loeffler]

I just got an email from Chengyang Bao (cc'ed) pointing out a typo in the Sage reference manual: in the class docstring for sage.modular.arithgroup.congroup_gammaH.GammaH_class, the formula "a, b \in H" should say "a, d \in H". (See https://doc.sagemath.org/html/en/reference/arithgroup/sage/modular/arithgroup/congroup_gammaH.html#sage.modular.arithgroup.congroup_gammaH.GammaH_class).

It's highly likely that this was my mistake originally, but it's been so long that I can't remember all the version control procedures etc needed to fix it – can some kind person make this single-character fix?

Best regards, David

[John Cremona]

On Thu, 10 Aug 2023, 08:13 David Loeffler, <d.loef...@cantab.net> wrote:

I just got an email from Chengyang Bao (cc'ed) pointing out a typo in the Sage reference manual: in the class docstring for sage.modular.arithgroup.congroup_gammaH.GammaH_class, the formula "a, b \in H" should say "a, d \in H". (See https://doc.sagemath.org/html/en/reference/arithgroup/sage/modular/arithgroup/congroup_gammaH.html#sage.modular.arithgroup.congroup_gammaH.GammaH_class).

It's highly likely that this was my mistake originally, but it's been so long that I can't remember all the version control procedures etc needed to fix it – can some kind person make this single-character fix?

I will, no problem. I'll cc you on a new GitHub issue but you can ignore any notifications you get.

John

Best regards, David

--
You received this message because you are subscribed to the Google Groups "sage-nt" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-nt+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-nt/CANDN%3Dhyer%2BXFENWm8%2BU1_%3DAGXgVp2Ed_SAOgRjmXbBDHafn5BQ%40mail.gmail.com.

[John Cremona]

The issue is at https://github.com/sagemath/sage/issues/36058 and the PR whcih fixes it is https://github.com/sagemath/sage/pull/36062.

I expect that this change will get into version 10.1.

John

[William Stein]

Thanks John!

For posterity is there a quick summary of "all the version control
procedures etc needed to do a single-character fix"?

- William

> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-nt/CAD0p0K6fZDEEdRgt1zBfKYE-7GU5ghM02H25JyJV0z5gYqoVJg%40mail.gmail.com.



--
William (http://wstein.org)

[John Cremona]

On Thu, 10 Aug 2023 at 16:44, William Stein <wst...@gmail.com> wrote:

Thanks John!

For posterity is there a quick summary of "all the version control
procedures etc needed to do a single-character fix"?

Good question!  In theory one can make edits to the files directly on github without even creating a PR, but I'm sure that I don't have the right permissions for that.

1. I picked a computer on which I had already built sage-10.0 in my own filespace, not the system-wide one.

2.  I did "git pull upstream develop", then both ./bootstrap and ./configure.

3. I tried "MAKE=make -j30 make" but it failed, and for some reason I can't remember I failed a simple "make" too, so I did "make clean" first and then "make".  That took many hours (single-threaded though I could have easily used 30 or more).

4. I created a new git branch, madethe one character change, and did "make" again.  That did not take too long.  So I committed and pushed to origin (=my clone on github, to which I had already pushed after the pull from upstream).

5. Meanwhile I had made the issue, given it the corrrect tags and assigned it to myself, quoting from David's email to explain the problem.

6. Then I made the PR and waited.

I have left this branch open on the computer I used in case some reviewer or the release manager wanted more changes.

I will ask on sage-devel why the parallel make approach I have often used in the past did not work, as that would have sped up the process considerably, as would having already built the latest beta -- but hey, I am retired, and while the computer was working I was in my hammock relaxing!

 

John

To view this discussion on the web visit https://groups.google.com/d/msgid/sage-nt/CACLE5GByGhPu%2BvHfQk13t7uxWPr0udY_c-LFzwVR-LJxAE2ZQg%40mail.gmail.com.