Ideals of Hecke algebras

[Preston Wake]

I wrote a patch (#6830) creating a class for ideals of a Hecke
algebra. I wrote it with a specific function in mind (the annihilator
of a Hecke module), so it probably doesn't do certain things that it
should. If someone wants to review this code, any help or advice or
opinions would be greatly appreciated.

[John Cremona]

Preston,

for some reason I could not view the patch on the ticket, though I
could download it.

Is that just me, or can other people see it as normal?

John

[gsw]

Hi,

I also only get (using Firefox 3.5):
HTML preview not available, since no preview renderer could handle
it. Try downloading the file instead.
Bummer, I would have liked to have a quick glance.
Are there any strange Unicode characters or such in it?
Was the patch produced with diff? With Mercurial?


Cheers,
Georg

[John Cremona]

The patch looks fine to me after downloading it.

However applying the patch to sage-4.1.1 failed :

applying ideal.patch
patching file sage/modular/hecke/algebra.py
Hunk #2 FAILED at 41
Hunk #3 FAILED at 18
2 out of 3 hunks FAILED -- saving rejects to file
sage/modular/hecke/algebra.py.rej

so I guess it's just a problem of the patch not being based on 4.1.1.

Preston, can you rebase the patch on 4.1.1 and upload it again?

John

2009/8/27 gsw <georg...@googlemail.com>:

[Preston Wake]

Oh, sorry, I think I fixed it now.

[John Cremona]

2009/8/27 Preston Wake <presto...@gmail.com>:

>
> Oh, sorry, I think I fixed it now.
>

OK, it looks ok now -- but I'm afrais I will not have time to review
it very soon...

John