Hi,
In reference to #35288, I have some doubts in the implementation part.
I have made following changes in the codebase:
1] Added deprecation warning for is_NumberFieldOrder function.
2] To make is_instance(ZZ, sage.rings.number_field.order.Order) return true, I have created abstract class IntegerRing_class which inherits from PrincipalIdealDomain and sage.rings.abc.Order and made it a base class of IntegerRing_class in integer_ring.pyx
file structure
| rings -
| abc.pxd
| abc.pyx
| integer_ring.pxd
| integer_ring.pyx
| number_field -
| order.py
Changes:
1] abc.pxd
from .ring cimport PrincipalIdealDomain
cdef class IntegerRing_class(PrincipalIdealDomain):
pass
2] abc.pyx
cdef class IntegerRing_class(PrincipalIdealDomain, Order):
pass
3] integer_ring.pxd
cdef class IntegerRing_class(sage.rings.abc.IntegerRing_class)
4] integer_ring.pyx
cdef class IntegerRing_class(sage.rings.abc.IntegerRing_class)
As I am new to Cython I need help in making IntegerRing_class base class of sage.rings.number_field.order.Order