Is there a way to see the content of a merged ticket ?

[Nathann Cohen]

Hellooooo everybody !

I was looking at a ticket like #15619, which has been merged a while ago, and I noticed that clicking on the branch's name leads nowhere as there is nothing in the branch that is not already in the trac/develop branch too.

Is there a way to see the list of modifications made by a ticket in Sage ? It is possible to find the individual commits on the page, but well... There may be many :-D

Nathann

[R. Andrew Ohana]

Not currently, but hopefully there will be in a couple of days (I'm working on implementing this, plus refactoring the trac plugin since it has grown quite a bit since its early days). Unfortunately it might not work with all the old tickets out there since branches may have been deleted, but in the future Volker's release management scripts should somehow indicate what commit he merges on a ticket when he closes it (and from that the trac plugin should be able to determine the commits and diff of that ticket).

--
You received this message because you are subscribed to the Google Groups "sage-git" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-git+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--

Andrew

[Nathann Cohen]

> Not currently, but hopefully there will be in a couple of days (I'm working on implementing this, plus refactoring the trac plugin since it has grown quite a bit since its early days). Unfortunately it might not work with all the old tickets out there since branches may have been deleted, but in the future Volker's release management scripts should somehow indicate what commit he merges on a ticket when he closes it (and from that the trac plugin should be able to determine the commits and diff of that ticket).

Okayyyyyyyyyy ! Thaaaaaaaaanks :-)

Nathann

[Volker Braun]

My "git trac" subcommand has a function for that:

$ git trac log 15619 --oneline

0418a3e Trac #15619: Pickling of immutable graphs

e761346 trac #15619: Pickling multigraphs with loops and labels

cabc969 Trac 15619: Review commit

c441178 trac #15619: bug in the former definition; exception to avoid it in the future

0229348 trac #15619: Pickling of immutable graphs

Or in long form:

$ git trac log 15619

commit 0418a3e971872c5a0140cda02e1256905b499fa1

Merge: dd71659 e761346

Author: Release Manager <rel...@sagemath.org>

Date:   Sat Jan 4 14:57:56 2014 -1000

    Trac #15619: Pickling of immutable graphs

    

    Before

    {{{

    sage: g=Graph(graphs.PetersenGraph(),immutable=True)

    sage: g == loads(dumps(g))

    ...

    TypeError: __cinit__() takes exactly 1 positional argument (0 given)

    }}}

    

    After

    {{{

    sage: g=Graph(graphs.PetersenGraph(),immutable=True)

    sage: g == loads(dumps(g))

    True

    }}}

    

    URL: http://trac.sagemath.org/15619

    Reported by: ncohen

    Ticket author(s): Nathann Cohen

    Reviewer(s): Simon King

commit e761346c888f8ef6f5dd5b43f52b20d23fef500c

Author: Nathann Cohen <nathan...@gmail.com>

Date:   Fri Jan 3 14:24:22 2014 +0100

    trac #15619: Pickling multigraphs with loops and labels

commit cabc96968cab75cbca1e85f1e8efc7b3c50f85e7

Author: Simon King <simon...@uni-jena.de>

Date:   Fri Jan 3 13:44:33 2014 +0100

    Trac 15619: Review commit

commit c4411781fa8a64d3e89568069ad85caab47b81d2

Author: Nathann Cohen <nathan...@gmail.com>

Date:   Thu Jan 2 21:25:26 2014 +0100

    trac #15619: bug in the former definition; exception to avoid it in the future

commit 02293487b6268d373896d4c18b0a41a54ef36acd

Author: Nathann Cohen <nathan...@gmail.com>

Date:   Thu Jan 2 11:51:29 2014 +0100

    trac #15619: Pickling of immutable graphs