Branch view on Trac shows only one commit

25 views
Skip to first unread message

Jeroen Demeyer

unread,
Jan 8, 2014, 3:59:30 AM1/8/14
to sage...@googlegroups.com
On http://trac.sagemath.org/ticket/13379, when I click on
the branch, I get taken to the page

http://git.sagemath.org/sage.git/diff/?id2=develop&id=u%2Fpbruin%2F13379-splitting_field

which shows the diff of only the *first* commit of the branch, not the
*second* one. What is going on here?

Jeroen Demeyer

unread,
Jan 8, 2014, 4:07:49 AM1/8/14
to sage...@googlegroups.com
Same problem on
http://git.sagemath.org/sage.git/diff/?id2=develop&id=u%2Fjdemeyer%2Fticket%2F15614
where all but the last commit is shown.

Is this a static page which isn't regenerated properly?

R. Andrew Ohana

unread,
Jan 8, 2014, 4:11:00 AM1/8/14
to sage...@googlegroups.com
Apparently the order of id and id2 matters. The links on trac should now be fixed (the old links will still be broken).

--
Andrew

Jeroen Demeyer

unread,
Jan 8, 2014, 4:15:35 AM1/8/14
to sage...@googlegroups.com
On 2014-01-08 10:11, R. Andrew Ohana wrote:
> Apparently the order of id and id2 matters. The links on trac should now
> be fixed (the old links will still be broken).

Thanks!

Jeroen Demeyer

unread,
Jan 8, 2014, 3:11:26 PM1/8/14
to sage...@googlegroups.com
On 2014-01-08 10:11, R. Andrew Ohana wrote:
> Apparently the order of id and id2 matters. The links on trac should now
> be fixed (the old links will still be broken).

This still shows a wrong diff:
http://git.sagemath.org/sage.git/diff/?id=u%2Fjdemeyer%2Fticket%2F15335&id2=develop

Commit 214bf49a7f28dd69489a874aba8037b4f9b64194 doesn't appear in the diff.

R. Andrew Ohana

unread,
Jan 8, 2014, 5:19:25 PM1/8/14
to sage...@googlegroups.com
It seems like cgit may be doing some caching or something with their queries. I've changed all the urls to cgit to use the sha1 hashes directly, so cached old results shouldn't be an issue anymore (since the queries to cgit will now always change when branches move).




--
You received this message because you are subscribed to the Google Groups "sage-git" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-git+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



--
Andrew
Reply all
Reply to author
Forward
0 new messages