reviewer role on github

[Martin R]

I was unable to find out how I declare myself as reviewer in the new workflow.

This question applies to

* pull requests without issue (I'm not sure yet how they work: given a number like #35053, how can I see issue and pull request associated to it?

* issues without pull requests.

Martin

[Kwankyu Lee]

I suggest this procedure:

You open an issue: "promote me to a reviewer". Then if you get enough hearts from other reviewers,  an admin promotes you.

[Martin R]

In which repository?

Does this mean that researchers cannot become reviewers immediately anymore?

I am very puzzled.

Martin

[David Roe]

I think the interface only allows reviewers for PRs, and not for issues (though you could always make a comment on an issue declaring your intention to review any resulting PR).

For PRs, you have a couple options:

1. At the top right of the PR, there's a "Reviewers" box, with a gear icon next to it.  If you click on the gear, it will show you a bunch of people, with yourself as first.  You can assign yourself as a reviewer (and possibly request other people as reviewers).  Please let me know if you don't see the gear or the list of people, since this may depend on your role in the repository.

2. If you click on the "Files changed" tab, you can add comments on lines and at the top right there should be a green button "Review Changes".

David

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/0d2dab52-0e74-4446-9256-f42eaa5240b0n%40googlegroups.com.

[David Roe]

Permission-wise, I think the only required permissions to review are Read permissions, so I don't think it should be technically restricted.

David

--

You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/2b2b0090-6d44-4e73-acc8-338ce589bbdfn%40googlegroups.com.

[Martin R]

On Friday, 10 February 2023 at 11:44:53 UTC+1 David Roe wrote:

I think the interface only allows reviewers for PRs, and not for issues (though you could always make a comment on an issue declaring your intention to review any resulting PR).

For PRs, you have a couple options:

1. At the top right of the PR, there's a "Reviewers" box, with a gear icon next to it.  If you click on the gear, it will show you a bunch of people, with yourself as first.  You can assign yourself as a reviewer (and possibly request other people as reviewers). 

Excellent, this is what I was looking for!

Martin

[Kwankyu Lee]

On Friday, February 10, 2023 at 7:33:51 PM UTC+9 Martin R wrote:

In which repository?

Here: https://github.com/sagemath/sage/issues 

Does this mean that researchers cannot become reviewers immediately anymore?

You first become a member of sage organization, and then be promoted to Triage team (of reviewers).

[David Roe]

I think you can review tickets without being on the Triage team (that's only required for changing labels).
David 

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/a42527ef-61bd-499a-a2dd-2c69cd17f1a7n%40googlegroups.com.