Nice catch indeed. I am not sure that "scaled=True/False" is the most
flexible design. You might just want to apply *some* scale, not
necessarily the one making the max length being one. I imagine that it
would be nice to allow "scaled" to be a positive floating point
number. In other words
if scaled is True: # boolean
scaled_vectors = [v/max_len for v in vectors]
elif scaled is False: # boolean
scaled_vectors = vectors
else: # assume that scaled is a ratio
scaled = float(scaled)
assert scaled > 0
scaled_vectors = [v / scaled for v in vectors]
What do you think?
Do you know how to open a ticket on https://trac.sagemath.org? Details
are in the developer guide
(https://doc.sagemath.org/html/en/developer/index.html).
Nice catch indeed. I am not sure that "scaled=True/False" is the most
flexible design. You might just want to apply *some* scale, not
necessarily the one making the max length being one. I imagine that it
would be nice to allow "scaled" to be a positive floating point
number. In other words
if scaled is True: # boolean
scaled_vectors = [v/max_len for v in vectors]
elif scaled is False: # boolean
scaled_vectors = vectors
else: # assume that scaled is a ratio
scaled = float(scaled)
assert scaled > 0
scaled_vectors = [v / scaled for v in vectors]
What do you think?
Do you know how to open a ticket on https://trac.sagemath.org? Details
are in the developer guide
(https://doc.sagemath.org/html/en/developer/index.html).
I think it is desirable to use the same argument conventions as the
method VectorField.plot(). In particular use `scale` and not `scaled`.
I don't know whether VectorField.plot() supports a default rescaling
as you proposed.
Sure. You can go on. Don't forget to mention the ticket number you
open in this e-mail discussion.