is_integral_domain crappy output

0 views
Skip to first unread message

Robert Miller

unread,
Dec 3, 2007, 3:49:52 PM12/3/07
to sage-devel
In sage/rings/quotient_ring.py, we have the following (line 220 in
2.8.14):
try:
return self.defining_ideal().is_prime()
except NotImplementedError:
return False

Why the heck don't we just propagate the NotImplementedError!?!

William Stein

unread,
Dec 3, 2007, 3:58:57 PM12/3/07
to sage-...@googlegroups.com

Good point. Change it and submit a patch. And make sure to doctest
everything, and include doctests illustrating your patch.

-- William

Reply all
Reply to author
Forward
0 new messages