set_legend_options and set_aspect_ratio don't seem to do anything
Dan Drake
I'm trying to get my plots to look right, and I've discovered that I
can't alter the legend or aspect ratio with the relevant "set_" functions:
sage: q = plot(tan(x), (x,-1,1))
sage: q.set_aspect_ratio(5)
...which has no affect on q. Likewise:
sage: q = plot(tan(x), (x,-1,1))
sage: q.set_legend_options(title='tangent!')
does nothing. Am I doing something wrong? Have I found some bugs?
Dan
--
--- Dan Drake
----- http://mathsci.kaist.ac.kr/~drake
-------
Jason Grout
> It seems that I've discovered more broken things in the plotting code!
>
> I'm trying to get my plots to look right, and I've discovered that I
> can't alter the legend or aspect ratio with the relevant "set_" functions:
>
> sage: q = plot(tan(x), (x,-1,1))
> sage: q.set_aspect_ratio(5)
>
> ...which has no affect on q.
This is fixed in #11963 (needs review! :)
Likewise:
>
> sage: q = plot(tan(x), (x,-1,1))
> sage: q.set_legend_options(title='tangent!')
>
> does nothing. Am I doing something wrong? Have I found some bugs?
I don't know about this. It would be something to look into. It might
be better to just have a function to set the show options for a figure,
rather than specific setter functions for each possible show option.
Something like:
q.set_show_options(legend_label='tangent')
which would be the same as:
plot(tan(x), (x,-1,1),legend_label='tangent')
Jason
kcrisman
> > sage: q = plot(tan(x), (x,-1,1))
> > sage: q.set_legend_options(title='tangent!')
>
> > does nothing. Am I doing something wrong? Have I found some bugs?
>
> I don't know about this. It would be something to look into. It might
first to do anything with it. The title is referring to the title of
the box with the legends.
sage: p = plot(tan(x),-1,1,legend_label='Tangent!')
sage: p # legend for this func
sage: p.set_legend_options(title='Mine')
sage: p # title to the box
sage: p += plot(-tan(x),-1,1,legend_label='Neg.Tan!')
sage: p # both functions in legend - notice the title is gone, perhaps
this is a bug in addition of plots
sage: p.set_legend_options(title='Mine')
sage: p # now the title to the box is back
Dan and Jason, what do you think the bug here is? It seems like at
least the addition thing is. But having a title to an empty legend
box seems silly.
- kcrisman
Dan Drake
> This is fixed in #11963 (needs review! :)
I looked over your patch and it seems good. I'll check it out tomorrow
morning when I'm at my work computer.
> Likewise:
> >
> >sage: q = plot(tan(x), (x,-1,1))
> >sage: q.set_legend_options(title='tangent!')
> >
> >does nothing. Am I doing something wrong? Have I found some bugs?
>
> I don't know about this. It would be something to look into. It
> might be better to just have a function to set the show options for
> a figure, rather than specific setter functions for each possible
> show option. Something like:
>
> q.set_show_options(legend_label='tangent')
>
> which would be the same as:
>
> plot(tan(x), (x,-1,1),legend_label='tangent')
That could be convenient. I'm producing my plots in one function and
showing them in another, so it's nice to be able to alter things after
the "production" step.
kcrisman
> > q.set_show_options(legend_label='tangent')
>
> > which would be the same as:
>
> > plot(tan(x), (x,-1,1),legend_label='tangent')
>
> That could be convenient. I'm producing my plots in one function and
> showing them in another, so it's nice to be able to alter things after
> the "production" step.
things, which allow for some nice fine-grained control without using
big hammers.
Dan Drake
Now has a positive review. Thanks for fixing that part of my problem!
By the way, my recent flurry of complaints about various plotting things
are all related to this worksheet that I've been working on to
demonstrate complex contour integration:
https://sagenb.kaist.ac.kr:8066/home/pub/46/