> +1 on the spkg, but I would greatly prefer to merge the 0.7 release
> instead of the currently optional 0.4.1 release.
The main problem with 0.7 is that the tuning process is quite slow,
and needs more work to make it feasible during the sage build. I will
be addressing this in 0.8.
Also there was a slight interface change somewhere between 0.4.1 and
0.7 which will make hypellfrob (ticket #1568) break. I will need to
supply updated code for that too.
david
Enthusiastic +1
The package is tiny, currently builds in 4 seconds on my laptop, and the
code is quite pretty. Also, the functionality is clearly very relevant to
Sage.
-- William
--
William Stein
Associate Professor of Mathematics
University of Washington
http://wstein.org
Another very enthusiastic +1.
-cc
definitely +1
Martin
--
name: Martin Albrecht
_pgp: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x8EF0DC99
_www: http://www.informatik.uni-bremen.de/~malb
_jab: martinr...@jabber.ccc.de
> Hi all,
>
> I propose making the zn_poly library a standard spkg in Sage, and
> hereby request a vote on the matter.
>
> Disclaimer: I am the author of zn_poly.
>
> Here is the ticket:
>
> http://sagetrac.org/sage_trac/ticket/1567
>
> This spkg has been in the optional repository for about three months.
+1 from me too. I would like to see a .pxd file for easy use from
Sage, but I'm sure that's on your todo list.
- Robert
> +1 from me too. I would like to see a .pxd file for easy use from
> Sage, but I'm sure that's on your todo list.
It is indeed on my list.
david
+1 pending easy use from Sage.
Independent of the discussion of znpoly, (which honestly, I'm rather excited about) I think this should be one of the requirements for including any (standard) spkg in Sage. Otherwise, what's the point?
> >> +1 from me too. I would like to see a .pxd file for easy use from
> >> Sage, but I'm sure that's on your todo list.
> >
> > It is indeed on my list.
>
> +1 pending easy use from Sage.
>
> Hey, that's an *extremely* interesting point! I think you're saying
> that znpoly's spkg should be standard in Sage until it is possible
> to actually use it from Sage. If the author hasn't at least done that
> in the last few months, perhaps making it a requirement for inclusion
> in Sage will motivate him to do so!
>
> Indeed -- David Harvey -- I think Tom has a very good point.
> Perhaps znpoly shouldn't be in sage until I can at least do
> sage: from sage.libs.znpoly.all import znpoly
> sage: znpoly([...])
Well, I'll leave it to the list to decide whether this should be a
requirement for inclusion as a standard spkg, but let me say a few
relevant things.
First, regardless of whether there is "direct access" to zn_poly from
Sage, it simply won't be possible to incorporate my faster
hyperelliptic curve zeta function code (http://trac.sagemath.org/
sage_trac/ticket/1568) until zn_poly is included. So if that counts
as "using zn_poly from Sage", then I think that answers the question.
I mean, for the moment you could just think of it as an auxiliary
library that's required to make the zeta function code work.
Second, the interface is still not complete enough to be worth
wrapping. I don't want to tie myself down too much yet, in terms of
making hard-to-reverse design decisions about the interface. When I
am more comfortable about how the interface looks, then I will write
a wrapper.
If people feel more strongly that a wrapper is necessary, I would
prefer to withdraw both patches and come back with more code in a few
months, rather than put in a wrapper now.
david
On Wed, 19 Mar 2008, David Harvey wrote:
Good point. I retract my last statement. Being useful for an application is generally more important than having a wrapper.
I have immediate uses for the new zeta function code and would
appreciate it being included. It sounds like I should install
zn_poly and the new patch and referee.
Nick
I don't think a full-blown wrapper is a requirement (this can be a
fair amount of work)--but given that you have to write a C program to
try it out how many people have actually tried to use it?
I'd be happy to provide a .pxd myself in the next couple days. My
only concern is how stable the API is.
- Robert
>> If people feel more strongly that a wrapper is necessary, I would
>> prefer to withdraw both patches and come back with more code in a few
>> months, rather than put in a wrapper now.
>
> I don't think a full-blown wrapper is a requirement (this can be a
> fair amount of work)--but given that you have to write a C program to
> try it out how many people have actually tried to use it?
If you mean "how many people have tried to use the spkg", well no-one
has really used it except for me, via the zeta function code. Mike
Hansen also commented in december on ticket #1568 that he installed
the zn_poly spkg, and applied the zeta function patch, and all
doctests passed successfully. Therefore at least one person other
than me has computed at least one zeta function using this code, from
within Sage. The zeta function code #includes a zn_poly header file
and calls at least one zn_poly function to multiply polynomials, so
at that most basic level it seems to be working.
> I'd be happy to provide a .pxd myself in the next couple days. My
> only concern is how stable the API is.
The API is insufficiently stable to provide a .pxd file at this point.
david
OK, that's good to know.
I still say an enthusiastic +1, it's being used in the zeta function
code and the code looks good to me.
- Robert