python3 patchbot

98 views
Skip to first unread message

Daniel Krenn

unread,
Apr 17, 2019, 9:06:59 AM4/17/19
to sage-...@googlegroups.com
Is it possible to set up a patchbot for running tests of SageMath on
Python3?

E. Madison Bray

unread,
Apr 17, 2019, 10:00:52 AM4/17/19
to sage-devel
On Wed, Apr 17, 2019 at 3:06 PM Daniel Krenn <kr...@aon.at> wrote:
>
> Is it possible to set up a patchbot for running tests of SageMath on
> Python3?

Yes, I believe so. Frédéric would know the specifics since I think he
made it work. According to the docs you have to put

"tested_files": "py3"

in the patchbot config file (see
https://wiki.sagemath.org/patchbot#Configuration)

But one would also have to ensure that sage is configure with
`--with-python=3` when doing builds, and I'm not exactly sure how best
to force the patchbot to do that. Certainly one way would be to
export the non-obvious environment variable

export PREREQ_OPTIONS="--with-python=3"

as that is passed to `./configure` by the main Makefile.

Daniel Krenn

unread,
Apr 18, 2019, 2:53:29 AM4/18/19
to sage-...@googlegroups.com
Ok, thank you. I've set something up which is testing its base right
now. So let's see if this works out :)

Frédéric Chapoton

unread,
Apr 18, 2019, 3:39:31 AM4/18/19
to sage-devel
What do you expect to do ?

(1) run all the tests and see the 94 remaining failing files ?

(2) or run only python3-certified tests and check that they pass on your machine ?

I am doing (1) after almost every beta release. I have never tried (2), although I vaguely remember that Samuel Lelievre once asked for something like that, and I may have prepared the ground for it (I forgot about that), but never for any feedback.

It is not clear to me whether or not the "--with-python=3" in configure is robust enough to survive all patchbots cleaning operations.

Frederic

Frédéric Chapoton

unread,
Apr 18, 2019, 5:57:19 AM4/18/19
to sage-devel
I see that you tried option (2). Not quite successful, it seems.

Your patchbot shows a failure in

sage -t --long src/sage/modular/pollack_stevens/padic_lseries.py

Does it pass when you run it manually ?

F


Le mercredi 17 avril 2019 15:06:59 UTC+2, Daniel Krenn a écrit :

Samuel Lelievre

unread,
May 7, 2019, 8:17:46 PM5/7/19
to sage-devel
Frédéric wrote:

> [...] although I vaguely remember that Samuel Lelievre
> once asked for something like that, and I may have
> prepared the ground for it (I forgot about that),
> but never for any feedback.

Yes, I was asking about that a while ago, and it took me
a while to experiment and to set things up. I think I now
have two patchbots trying out tickets:
- one for Python2-based SageMath,
- one for Python3-based SageMath.

Let me know if you spot anything wrong with my setup.

Reply all
Reply to author
Forward
0 new messages