Bug in quaternion orders over number fields

[Eloi Torrents]

When constructing a quaternion order over a number field I get this error:

from sage.algebras.quatalg.quaternion_algebra import QuaternionOrder
F.<w> = NumberField(x**2-x-1)
A.<i,j,k> = QuaternionAlgebra(F, -1, -1)

QuaternionOrder(A, [1, 3*i, 1/2*w + 1/2 + (3/2*w + 1)*i + 1/2*j, 1/2*w + (3/2*w - 1/2)*i + 1/2*k])

https://pastebin.com/rCi9TsbU

And this is the fix needed, but I don't know how should I contribute it: https://github.com/sagemath/sage/compare/develop...Eloitor:sage:develop

I tried to find a ticket about this but didn't find anything. Should I open one?

Eloi

[Dima Pasechnik]

yes, open a ticket (logging in with your github login), then put up
your branch for review there.

Specifically, add remote to your git repo:

$ git remote add trac g...@trac.sagemath.org:sage.git

make sure your branch has correct name - it should start with
"u/gh_Eloitor/", e.g.

$ git checkout -b u/gh_Eloitor/QuaternionOrder_fix

and push it it to trac:

$ git push trac HEAD

(make sure your branch is based on the latest beta, currently 9.8.beta2)

On the ticket, enter u/gh_Eloitor/QuaternionOrder_fix into "branch" tab

HTH
Dima




>
> Eloi
>
> --
> You received this message because you are subscribed to the Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/5e069544-f8cb-43b8-9bf4-6ed57e06a9acn%40googlegroups.com.

[Eloi Torrents]

I followed your instructions but I got this message when pushing:

$ git push trac HEAD

Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 4 threads
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 661 bytes | 50.00 KiB/s, done.
Total 7 (delta 6), reused 0 (delta 0), pack-reused 0
remote: FATAL: W refs/heads/u/gh_Eloitor/QuaternionOrder_fix sage gh-Eloitor DENIED by fallthru
remote: error: hook declined to update refs/heads/u/gh_Eloitor/QuaternionOrder_fix
To trac.sagemath.org:sage.git
 ! [remote rejected]         HEAD -> u/gh_Eloitor/QuaternionOrder_fix (hook declined)
error: failed to push some refs to 'trac.sagemath.org:sage.git'

Eloi

[Dima Pasechnik]

On Fri, Oct 21, 2022 at 8:30 PM Eloi Torrents <eloi.to...@gmail.com> wrote:
>
> I followed your instructions but I got this message when pushing:

I assumed you have ssh key uploaded to your github account.
Do you have any keys here:
https://github.com/settings/keys

?

> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/ba73916e-211d-4a12-908e-192617a7b1f6n%40googlegroups.com.

[Eloi Torrents]

yes... I tried to add it and I got the message "Key is already in use".

[Dima Pasechnik]

On Sat, 22 Oct 2022, 06:24 Eloi Torrents, <eloi.to...@gmail.com> wrote:

yes... I tried to add it and I got the message "Key is already in use".

please see

https://docs.github.com/en/authentication/troubleshooting-ssh/error-key-already-in-use

looks like you need to generate a new key pair and upload a new key.

To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/075dfb31-9e6f-4379-9ecc-d22b51dd98d6n%40googlegroups.com.

[Eloi Torrents]

I generated a new key pair, I added it to trac but I keep getting the same error message when pushing:

remote: FATAL: W refs/heads/u/gh_Eloitor/QuaternionOrder_fix sage gh-Eloitor DENIED by fallthru
remote: error: hook declined to update refs/heads/u/gh_Eloitor/QuaternionOrder_fix
To trac.sagemath.org:sage.git
 ! [remote rejected]         HEAD -> u/gh_Eloitor/QuaternionOrder_fix (hook declined)
error: failed to push some refs to 'trac.sagemath.org:sage.git'

I also tried with the new ssh key added to my github account, but I get the same error.

What should I do?

Thank you

[Dima Pasechnik]

On Wed, 26 Oct 2022, 11:47 Eloi Torrents, <eloi.to...@gmail.com> wrote:

I generated a new key pair, I added it to trac but I keep getting the same error message when pushing:

apologies, it should be u/gh-Eloitor...,

not u/gh_Eloitor...

To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/d6cb6f61-3bb9-4397-8207-1995e7628460n%40googlegroups.com.