cysignals/sig_on...sig_off

115 views
Skip to first unread message

jonatha...@googlemail.com

unread,
Apr 30, 2023, 10:49:44 AM4/30/23
to sage-devel
Hi,

it's been over a year since the last activity on https://github.com/sagemath/cysignals.

This could well be, because it is a good shape, but looking at the issues, I'm not too sure about that. Here are some issues, I know of:

- sig_on/sig_off is poorly maintained and not thread safe
- cysignals is not pip installable and highly platform dependent (and on a platform even depends very much on the compiler).
- Memory: Interrupting sig_on...sig_off will not clean up the heap.

I would argue:

-  To my knowledge, `sig_check` is pretty much equivalent to `PyErr_CheckSignals` (https://github.com/sagemath/cysignals/issues/145)
- Instead of using `sig_on...sig_off` for our own functions, we should check for signals at reasonable places.
- External calls should be interrupted with standard tools and not our own custom tool.

While the action on the first item is quite obvious (I didn't even check if anything needs to be done here), I have not done my research on the second point and what the alternatives are.

Before I dig into possible options of replacing `sig_on...sig_off`, I would like to gather your opinions:

Does cysignals get enough support to keep going or do we want to try a different approach? This different approach will for sure not be as efficient, but will probably need less effort to maintain.

Matthias Koeppe

unread,
Apr 30, 2023, 1:27:50 PM4/30/23
to sage-devel
I would suggest looping in the Cython community (cython-users list) on these questions.

Could you elaborate on "cysignals is not pip-installable"? We are even building platform wheels - https://pypi.org/project/cysignals/#files

Jonathan Kliem

unread,
Apr 30, 2023, 1:51:42 PM4/30/23
to sage-devel
Sorry about that. It is pip installable of course. However, it uses some non standard setup.

I've been too long out of the topic. I just noticed that there is no active development. This might be fine. But I'm not sure.

--
You received this message because you are subscribed to a topic in the Google Groups "sage-devel" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sage-devel/MYV3wDR83m4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/dfe10ff3-aa4b-4587-8e60-4ff60769a9edn%40googlegroups.com.

David Roe

unread,
Apr 30, 2023, 10:03:39 PM4/30/23
to sage-...@googlegroups.com
On Sun, Apr 30, 2023 at 10:49 AM 'jonatha...@googlemail.com' via sage-devel <sage-...@googlegroups.com> wrote:
Does cysignals get enough support to keep going or do we want to try a different approach? This different approach will for sure not be as efficient, but will probably need less effort to maintain.

sig_on/sig_off can be used in library interfaces where the performance impact may be noticeable.  I'd like to see a direct comparison before putting in much effort to switch to something else.
David

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/a8883260-2b4b-4cd4-8980-f1fea2070c10n%40googlegroups.com.
Message has been deleted

Dima Pasechnik

unread,
May 5, 2023, 1:22:25 PM5/5/23
to sage-...@googlegroups.com
On Fri, May 5, 2023 at 5:12 PM sumaiya qureshi
<sumaiyaq...@gmail.com> wrote:
>
> Hey All!
>
> Please let me know I am included within the accepted organization or not?
>
> According to Karachi, Pakistan timezone last night was my GSoC'23 result.
>
> Please guide me through the procedure how to check my GSoC'23 result.
>
> Name :- Sumaiya Qureshi (Karachi, Pakistan)
>
> I opted for Improvements to mathematics interaction with the desired organization "Oppia" within Web category.
>
> Let me know if you all sage developers want further information regarding myself to search my result.

Why are you spamming this group by posting several copies of the same message?

>
> Regards,
> Sumaiya.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAChs6_mDQLMgn6DjuPbHZ3tbdvRrFkMDTNVdQPW-SydvD%3DvDRA%40mail.gmail.com.
>
> --
> You received this message because you are subscribed to the Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAOgrLb30UX3w5X2n1W%2BkXfjWZFRoVPc5BUMC_qFVkU07WXcobg%40mail.gmail.com.

David Roe

unread,
May 5, 2023, 4:23:50 PM5/5/23
to sage-devel
I've banned the user.
David

Reply all
Reply to author
Forward
0 new messages