closed tickets

57 views
Skip to first unread message

G. M.-S.

unread,
Jun 30, 2022, 12:00:46 PM6/30/22
to sage-...@googlegroups.com

Is there an easy way to get a branch with all closed tickets merged?

Does it make sense to work with such a branch instead of the last beta branch?  I.e., for tickets positively reviewed or needing review.

Guillermo


Dima Pasechnik

unread,
Jun 30, 2022, 12:02:32 PM6/30/22
to sage-devel
On Thu, Jun 30, 2022 at 5:00 PM G. M.-S. <list...@gmail.com> wrote:
>
>
> Is there an easy way to get a branch with all closed tickets merged?
>
> Does it make sense to work with such a branch instead of the last beta branch? I.e., for tickets positively reviewed or needing review.

Volker is against this.
(while such a branch exists, it's likely to get rewritten a lot before
it becomes a beta)

>
> Guillermo
>
>
> --
> You received this message because you are subscribed to the Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CANnG18_3xVngMffm2Op5Qvx%2B-YBdQ8o6mXZMmuSL-D21gGyg2w%40mail.gmail.com.

G. M.-S.

unread,
Jun 30, 2022, 12:11:51 PM6/30/22
to sage-...@googlegroups.com

Thanks Dima.

I asked because if the beta branch has problems you need to merge some tickets in order to make some progress with other tickets.
Last example:  #34025.

Guillermo

Dima Pasechnik

unread,
Jun 30, 2022, 2:16:34 PM6/30/22
to sage-devel
On Thu, Jun 30, 2022 at 5:11 PM G. M.-S. <list...@gmail.com> wrote:
>
>
> Thanks Dima.
>
> I asked because if the beta branch has problems you need to merge some tickets in order to make some progress with other tickets.
> Last example: #34025.

it would be harmless to merge the branch of #34025, i.e.
u/gh-DavidAyotte/fix_blocker_in_hecke_series
into the branch you work on.
(don't forget to specify #34025 as a dependency in the ticket description then)

Dima

>
> Guillermo
>
> On Thu, 30 Jun 2022 at 18:02, Dima Pasechnik <dim...@gmail.com> wrote:
>>
>> On Thu, Jun 30, 2022 at 5:00 PM G. M.-S. <list...@gmail.com> wrote:
>> >
>> > Is there an easy way to get a branch with all closed tickets merged?
>> >
>> > Does it make sense to work with such a branch instead of the last beta branch? I.e., for tickets positively reviewed or needing review.
>>
>> Volker is against this.
>> (while such a branch exists, it's likely to get rewritten a lot before
>> it becomes a beta)
>
>
> --
> You received this message because you are subscribed to the Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CANnG1897TG_PUORSnH3V1QnpKwsEv4GVqAwK5Rn3E9wAMLgqqQ%40mail.gmail.com.

Kwankyu Lee

unread,
Jul 1, 2022, 11:33:38 PM7/1/22
to sage-devel
On Friday, July 1, 2022 at 1:02:32 AM UTC+9 dim...@gmail.com wrote:
Volker is against this.
(while such a branch exists, it's likely to get rewritten a lot before
it becomes a beta)

When I first saw the notice of merge conflicts with Volker's branch and my positively-reviewed ticket, I thought wrongly that I need to resolve the merge conflicts with the Volker's branch. I didn't realize that I was supposed to identify those tickets among the tickets merged to Volker's branch that conflict with my ticket, and put those tickets as dependencies to my ticket. I think this should be explained somewhere, perhaps in the  notice itself.

Kwankyu Lee

unread,
Jul 2, 2022, 3:55:36 AM7/2/22
to sage-devel


On Saturday, July 2, 2022 at 12:33:38 PM UTC+9 Kwankyu Lee wrote:
... I think this should be explained somewhere, perhaps in the  notice itself.

Added to 


which needs review.
 
Reply all
Reply to author
Forward
0 new messages