Hi Simon,
I believe I wrote that, and it has been my experience that a "reviewer
patch" is often reviewed by the "main author."
As in a reviewer saying to the principal author "I like your patch,
and am ready to give it a positive review, but have posted a patch
with some changes. If you agree with the changes, go ahead and mark
the ticket as positive review."
Dragging John Palmieri into the discussion, see a recent example at:
http://trac.sagemath.org/sage_trac/ticket/10470
There was also a recent proposal about having a group approach to big
complicated tickets, where maybe there'd be some similar cross-
pollination, I'd imagine.
I shouldn't be in the business of making policy just because I wrote
an introduction to help newcomers to Sage development. So if you
think what I wrote went too far, was too exuberant, or others think
this practice is unwise, I'm happy to reflect community practice in
the (oft-delayed) update to this introduction that I've been plotting
for the past few weeks.
As in many things, my personal feeling is that common sense and good
judgement should trump strict rules.
Thanks for bringing this up.
Rob
On Apr 6, 11:21 pm, Simon King <
simon.k...@uni-jena.de> wrote:
> Hi!
>
> I read athttp://
www.sagemath.org/doc/developer/trac.html#reviewing-patches: