[Sage] #14783: Implement toggle group actions on posets
Sage
-------------------------------+--------------------------------------------
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: new
Priority: major | Milestone: sage-5.11
Component: combinatorics | Keywords: poset, combinat, days49
Work issues: | Report Upstream: N/A
Reviewers: | Authors: Jessica Striker
Merged in: | Dependencies: #12848
Stopgaps: |
-------------------------------+--------------------------------------------
1. Implement toggling a single elements in an order ideal
2. Toggle a list of elements
3. Implement row and column toggles
4. Implement promotion and rowmotion
5. Implement orbit structure calculator
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, and MATLAB
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Changes (by darij):
* status: new => needs_review
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:1>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by chapoton):
please add a commit message
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:2>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Description changed by darij:
Old description:
> 1. Implement toggling a single elements in an order ideal
> 2. Toggle a list of elements
> 3. Implement row and column toggles
> 4. Implement promotion and rowmotion
> 5. Implement orbit structure calculator
1. Implement toggling a single elements in an order ideal
2. Toggle a list of elements
3. Implement row and column toggles
4. Implement promotion and rowmotion
5. Implement orbit structure calculator
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:3>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by darij):
Right, done.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:4>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by chapoton):
for the bot:
apply trac_14783-toggles_on_order_ideals-jsdg.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:5>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by tscrim):
Hey Darij,
A few more things:
- There's a "TODO" on line 371 of `finite_posets.py`, I believe that
should be removed,
- `element_constructor` of `rowmotion_orbits` is not documented,
- "Returns" -> "Return",
- In `categories/posets.py`, could you make the {{{`I`}}}'s into
{{{``I``}}} and similar for {{{`v`}}} and {{{`vs`}}} (i.e. code
formatting),
- Could the `is_order_*` methods be moved into the category `Posets`?
Thanks,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:6>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by darij):
Good points, done! The diff for finite_posets.py is a bit weird, but it
should work. I've also caught and fixed two wrong docstrings in
sage/categories/posets.py.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:7>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Description changed by darij:
Old description:
> 2. Toggle a list of elements
> 3. Implement row and column toggles
> 4. Implement promotion and rowmotion
> 5. Implement orbit structure calculator
>
New description:
1. Implement toggling a single elements in an order ideal
2. Toggle a list of elements
3. Implement row and column toggles
4. Implement promotion and rowmotion
5. Implement orbit structure calculator
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:8>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by chapoton):
once again, your new patch needs a commit message, see the patchbot report
imho, having the patchbot green is a reasonable first step '''before'''
starting the review process
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:9>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by darij):
Huh? Doesn't it say "trac #14783: implement toggle operations on order
ideals of a poset"?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:10>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Report Upstream: N/A | Reviewers:
Authors: Jessica Striker | Merged in:
Dependencies: #12848 | Stopgaps:
Comment (by chapoton):
yes indeed, but for the some reasons the bot managed to stack two patches
that were not supposed to be stacked. And order-ideals.patch has no commit
message..
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:11>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Authors: Jessica Striker, Darij Grinberg | Merged in:
Dependencies: #12848 | Stopgaps:
---------------------------------------------------+------------------------
Changes (by {'newvalue': u'Jessica Striker, Darij Grinberg', 'oldvalue': u'Jessica Striker'}):
* status: needs_review => positive_review
* reviewer: => Travis Scrimshaw
* author: Jessica Striker => Jessica Striker, Darij Grinberg
Comment:
Looks good to me.
It's strange (and somewhat scary to me) the patchbot was able to apply
both patches...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:12>
Sage
Reporter: jessicapalencia | Owner: sage-combinat
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Dependencies: #12848 | Stopgaps:
---------------------------------------------------+------------------------
Comment (by darij):
Thank you!
(I also don't see why the patchbot has been trying to do so in the first
place...)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14783#comment:13>