[Sage] #14761: SkewTableau does follow global_options of Tableaux
Sage
-----------------------------+----------------------------------------------
Reporter: zabrocki | Owner: sage-combinat
Type: defect | Status: new
Priority: minor | Milestone: sage-5.11
Component: combinatorics | Keywords: tableaux, days49
Work issues: | Report Upstream: N/A
Reviewers: | Authors: zabrocki
Merged in: | Dependencies:
Stopgaps: |
-----------------------------+----------------------------------------------
{{{SkewTableau}}} should follow the same the conventions set in
`Tableaux.global_options` for the method `.pp()`. In particular, it
should follow `convention="French"` displayed in reverse order. This
should be changed in the method `_repr_diagram`
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14761>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, and MATLAB
Sage
Reporter: zabrocki | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics | Resolution:
Authors: | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Changes (by tscrim):
* status: new => needs_review
* reviewer: => Travis Scrimshaw
* milestone: sage-5.11 => sage-duplicate/invalid/wontfix
* author: zabrocki =>
Comment:
Just double check that everything is done in #14101, I think I ended up
taking care of all of it in there. (I hope you haven't done any work on
this Mike; sorry if you have.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14761#comment:1>
Sage
Reporter: zabrocki | Owner: sage-combinat
Type: defect | Status: needs_work
Component: combinatorics | Resolution:
Authors: | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
* status: needs_review => needs_work
Comment:
This covers .pp() but doesn't cover {{{latex}}}, or {{{display}}}. Are
you planning on adding those to #14101?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14761#comment:2>
Sage
Reporter: zabrocki | Owner: sage-combinat
Type: defect | Status: needs_review
Component: combinatorics | Resolution:
Authors: | Merged in:
------------------------------------+---------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
* dependencies: => #14101
Comment:
They are done in (the latest version of) #14101:
{{{
sage: S = SkewTableau([[None, None, 3], [1, 2, 4], [5]])
sage: S
[[None, None, 3], [1, 2, 4], [5]]
sage: S.pp()
. . 3
1 2 4
5
sage: SkewTableaux.global_options(convention="French")
sage: S.pp()
5
1 2 4
. . 3
sage: latex(S) # If you can parse this, you'll see it's in French notation
{\def\lr#1{\multicolumn{1}{|@{\hspace{.6ex}}c@{\hspace{.6ex}}|}{\raisebox{-.3ex}{$#1$}}}
\raisebox{-.6ex}{$\begin{array}[t]{*{3}c}\cline{1-1}
\lr{5}\\\cline{1-3}
\lr{1}&\lr{2}&\lr{4}\\\cline{1-3}
&&\lr{3}\\\cline{3-3}
\end{array}$}
}
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14761#comment:3>
Sage
Reporter: zabrocki | Owner: sage-combinat
Priority: minor | Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics | Resolution:
Authors: | Merged in:
Dependencies: #14101 | Stopgaps:
------------------------------------+---------------------------------------
Comment (by zabrocki):
I'm a little confused about what options are set where.
{{{
sage: SkewTableaux.global_options(latex="list")
...
ValueError: latex is not an option for skew tableaux
}}}
gives a traceback error.
That should read "list is not an option ..."
{{{
sage: Tableaux.global_options(display="diagram")
sage: SkewTableau([[None,1],[2]])
[[None, 1], [2]]
sage: SkewTableaux.global_options(display="diagram")
. 1
2
sage: SkewTableaux.global_options(display="compact")
...
ValueError: compact is not a valid value for display in the options for
skew tableaux
}}}
I wouldn't know to look for the global options in {{{SkewTableaux}}} to
set the diagram display given that "convention" and "latex" options can be
set in {{{Tableaux.global_options}}}
Shouldn't they consistently follow a single global options?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14761#comment:4>
Sage
Reporter: zabrocki | Owner: sage-combinat
Priority: minor | Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics | Resolution:
Authors: | Merged in:
Dependencies: #14101 | Stopgaps:
------------------------------------+---------------------------------------
Comment (by tscrim):
Ah, you're right. They should be much more constistant than they are. Will
fix #14101.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14761#comment:5>
Sage
Reporter: zabrocki | Owner: sage-combinat
Priority: minor | Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics | Resolution:
Authors: | Merged in:
Dependencies: #14101 | Stopgaps:
------------------------------------+---------------------------------------
Comment (by tscrim):
Alright they are now the same global options in #14101. I believe we can
close this ticket as a duplicate (and any other problems can be posted on
#14101).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14761#comment:6>