Re: Sagan 0.1.8

[Champ Clark III [Softwink]]

>
> I have updated the package to svn revision 128 and I can confirm that it
> seems ok.

Thank you very much..

> There is, however, another problem which may be more difficult to resolve:
> Opening the FIFO (src/sagan.c:532) is done earlier, before forking
> (src/sagan.c:568).
> While this may be a good idea for error handling, this cause a problem:
> opening a FIFO is blocking if no writer is connected [1]. This means
> that the init script will never return.
>
> There, imho, several solutions:
> - open the fifo in non-blocking mode (this may cause many changes the code)
> - open it after forking (but you'll never now it starting the daemon
> succeeded from the console, only in logs)
> - open in non-blocking mode and set it blocking after forking
>
> Personally, I'd suggest #1 even if it costs some changes ..
> What do you think of that ?

Ekkk. I just ran a test and see what your saying and thanks
for pointing that out. #1 is an idea, but opens up another can
of worms all together. #2 is okay, and Sagan has the code to deal
with the writer disappearing/reappearing. Let me poinder on this
a bit.

Out of curiosity, why are you leaning to #1?

I'm going to enter this into the bug tracker. Also, I moved
the mailing lists over to saga...@googlegroups.com.

Thanks again.

--
Champ Clark III | Softwink, Inc | 800-538-9357 x 101
http://www.softwink.com

GPG Key ID: 58A2A58F
Key fingerprint = 7734 2A1C 007D 581E BDF7 6AD5 0F1F 655F 58A2 A58F
If it wasn't for C, we'd be using BASI, PASAL and OBOL.

[Champ Clark III [Softwink]]

> While this may be a good idea for error handling, this cause a problem:
> opening a FIFO is blocking if no writer is connected [1]. This means
> that the init script will never return.
>
> There, imho, several solutions:
> - open the fifo in non-blocking mode (this may cause many changes the code)
> - open it after forking (but you'll never now it starting the daemon
> succeeded from the console, only in logs)
> - open in non-blocking mode and set it blocking after forking

I've commited into SVN #2 as at least a "temporary fix". It
now forks before opening. Let me know what you think