S3QL 5: _sqlite3ext.cpp missing?

[Daniel Jagszent]

Hello Nikolaus,

I tried building the release tarball of S3QL 5.0.0-pre1 but at the step
where I want to build_ext step I get the following error:

$ setup.py build_ext --inplace
running build_ext
building 's3ql.sqlite3ext' extension
creating build
creating build/temp.linux-x86_64-cpython-310
creating build/temp.linux-x86_64-cpython-310/src
creating build/temp.linux-x86_64-cpython-310/src/s3ql
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3
-Wall -g -O2 -fdebug-prefix-map=/build/s3ql-5.0.0=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -g
-I/root/.pyenv/versions/3.10.11/include/python3.10 -c
src/s3ql/sqlite3ext.cpp -o
build/temp.linux-x86_64-cpython-310/src/s3ql/sqlite3ext.o -Wall -Wextra
-Wconversion -Wsign-compare
src/s3ql/sqlite3ext.cpp:793:10: fatal error: _sqlite3ext.cpp: No such
file or directory
  793 | #include "_sqlite3ext.cpp"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
error: command '/usr/bin/gcc' failed with exit code 1

I also tried to run build_cython first (but that should not be
necessary, since the release tarball already includes sqlite3ext.cpp).

I have no experience with Cython but after reading
https://cython.readthedocs.io/en/latest/src/userguide/external_C_code.html#referencing-c-header-files
I suspect that the manual *header* file _sqlite3ext.cpp is missing?

[Nikolaus Rath]

On May 19 2023, Daniel Jagszent <dan...@jagszent.de> wrote:
> Hello Nikolaus,
>
> I tried building the release tarball of S3QL 5.0.0-pre1 but at the step
> where I want to build_ext step I get the following error:

[...]

>
> I have no experience with Cython but after reading
> https://cython.readthedocs.io/en/latest/src/userguide/external_C_code.html#referencing-c-header-files
> I suspect that the manual *header* file _sqlite3ext.cpp is missing?

Yes, thanks for the report! It was missing from the tarball since I
didn't update the MANIFEST. I just uploaded a fixed tarball.


Best,
-Nikolaus

--
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

[Daniel Jagszent]

Hello Nikolaus,

compiling the extension from the release tarball works now, thanks!

It looks like the release tarball (
https://github.com/s3ql/s3ql/releases/download/release-5.0.0-pre1/s3ql-5.0.0.tar.gz
) is from another commit than the corresponding tag (
https://github.com/s3ql/s3ql/archive/refs/tags/release-5.0.0-pre1.tar.gz
). Have a look at the attached diff for the changes.

Could you maybe upload the release tarball with after a hard reset of
your working copy to the release-5.0.0-pre1 tag ( sha
adb2d04c588b636a4251d8b4f455b36b92dbb33b )?

Thanks,
Daniel

[Nikolaus Rath]

On Mon, 22 May 2023, at 19:58, Daniel Jagszent wrote:
> Hello Nikolaus,
>
> compiling the extension from the release tarball works now, thanks!
>
> It looks like the release tarball (
> https://github.com/s3ql/s3ql/releases/download/release-5.0.0-pre1/s3ql-5.0.0.tar.gz
> ) is from another commit than the corresponding tag (
> https://github.com/s3ql/s3ql/archive/refs/tags/release-5.0.0-pre1.tar.gz
> ). Have a look at the attached diff for the changes.

Wops, looks like I accidentally created the tarball from the wrong branch. Should be fixed now.

Best,
-Nikolaus