[rubyripper] push by boukewou...@gmail.com - Don't use quotes around the ISRC tag in the cuesheet (issue 547). on 2012-12-27 19:48 GMT

[rubyr...@googlecode.com]

Revision: 61a20cc8135a
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Thu Dec 27 11:54:10 2012
Log: Don't use quotes around the ISRC tag in the cuesheet (issue 547).

http://code.google.com/p/rubyripper/source/detail?r=61a20cc8135a

Modified:
/lib/rubyripper/disc/cuesheet.rb
/spec/disc/cuesheet_spec.rb

=======================================
--- /lib/rubyripper/disc/cuesheet.rb Mon Oct 22 11:57:09 2012
+++ /lib/rubyripper/disc/cuesheet.rb Thu Dec 27 11:54:10 2012
@@ -112,7 +112,7 @@
def printTrackMetadata(track)
@cuesheet << " TITLE \"#{@md.trackname(track)}\""
@cuesheet << " PERFORMER \"#{@md.various? ?
@md.getVarArtist(track) : @md.artist}\""
- @cuesheet << " ISRC \"#{@cdrdao.getIsrcForTrack(track)}\"" unless
@cdrdao.getIsrcForTrack(track).empty?
+ @cuesheet << " ISRC #{@cdrdao.getIsrcForTrack(track)}" unless
@cdrdao.getIsrcForTrack(track).empty?
end

# print a line for the index of a track
=======================================
--- /spec/disc/cuesheet_spec.rb Mon Oct 22 11:57:09 2012
+++ /spec/disc/cuesheet_spec.rb Thu Dec 27 11:54:10 2012
@@ -90,13 +90,13 @@
cue.cuesheet.should == @cuesheet
end

- it "should write the ISRC for tracks where the info is found" do
+ it "should write the ISRC for tracks where the info is found without
quotes" do
cdrdao.stub!(:getPregapSectors).and_return 0
cdrdao.stub!(:getIsrcForTrack).with(1).and_return 'someISRCcode'
cdrdao.stub!(:getIsrcForTrack).with(2).and_return ''
cdrdao.stub!(:getIsrcForTrack).with(3).and_return 'someOtherISRCcode'
- @cuesheet.insert(4, ' ISRC "someISRCcode"')
- @cuesheet.insert(13, ' ISRC "someOtherISRCcode"')
+ @cuesheet.insert(4, ' ISRC someISRCcode')
+ @cuesheet.insert(13, ' ISRC someOtherISRCcode')
cue.test_printTrackDataImage('flac')
cue.cuesheet.should == @cuesheet
end