[rubyripper] 2 new revisions pushed by boukewou...@gmail.com on 2013-05-09 10:26 GMT

[rubyr...@googlecode.com]

2 new revisions:

Revision: ae21f8f229cb
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Thu May 9 05:01:40 2013
Log: Fix rspec test for scanDiscCdrdao.
http://code.google.com/p/rubyripper/source/detail?r=ae21f8f229cb

Revision: a59a5a350efb
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Thu May 9 05:26:01 2013
Log: Fix remaining rspec errors and cleanup utf-8 filtering as well.
http://code.google.com/p/rubyripper/source/detail?r=a59a5a350efb

==============================================================================
Revision: ae21f8f229cb
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Thu May 9 05:01:40 2013
Log: Fix rspec test for scanDiscCdrdao.

http://code.google.com/p/rubyripper/source/detail?r=ae21f8f229cb

Modified:
/spec/disc/scanDiscCdrdao_spec.rb

=======================================
--- /spec/disc/scanDiscCdrdao_spec.rb Thu Dec 27 12:21:52 2012
+++ /spec/disc/scanDiscCdrdao_spec.rb Thu May 9 05:01:40 2013
@@ -30,7 +30,7 @@
context "In case cdrdao exits with an error" do
it "should detect cdrdao is not installed" do
exec.stub!(:launch).and_return(nil)
- log.should_receive(:<<).with('Error: cdrdao is needed, but not
detected on your system!')
+ log.should_receive(:<<).with('Error: cdrdao is required, but not
detected on your system!')
cdrdao.scanInBackground()
cdrdao.joinWithMainThread(log)
end
@@ -58,7 +58,9 @@

it "should not give a warning with correct results" do
exec.stub!(:launch).and_return('ok')
- log.should_receive(:<<).with("No pregaps, silences, pre-emphasis or
data tracks detected\n\n")
+ log.should_receive(:<<).with("\nADVANCED TOC ANALYSIS (with
cdrdao)\n")
+ log.should_receive(:<<).with("...please be patient, this may take a
while\n\n")
+ log.should_receive(:<<).with("No pregap, silence, pre-emphasis or
data track detected\n\n")
cdrdao.scanInBackground()
cdrdao.joinWithMainThread(log)
cdrdao.error.nil? == true

==============================================================================
Revision: a59a5a350efb
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Thu May 9 05:26:01 2013
Log: Fix remaining rspec errors and cleanup utf-8 filtering as well.

http://code.google.com/p/rubyripper/source/detail?r=a59a5a350efb

Modified:
/lib/rubyripper/metadata/filter/filterAll.rb

=======================================
--- /lib/rubyripper/metadata/filter/filterAll.rb Wed Feb 1 11:11:09 2012
+++ /lib/rubyripper/metadata/filter/filterAll.rb Thu May 9 05:26:01 2013
@@ -31,23 +31,13 @@
# underscores instead of spaces
item.gsub!('_', ' ') unless @prefs.noSpaces

- if item.respond_to?(:encoding)
- # prepare for byte substitutions
- enc = item.encoding
- item.force_encoding("ASCII-8BIT")
- end
-
# replace utf-8 single quotes with latin single quote
- item.gsub!(/\342\200\230|\342\200\231/, "'")
+ # see also http://www.utf8-chartable.de/unicode-utf8-table.pl
+ item.gsub!(/\u{02018}|\u{02019}/, "'")

# replace utf-8 double quotes with latin double quote
- item.gsub!(/\342\200\234|\342\200\235/, '"')
+ item.gsub!(/\u{0201c}|\u{0201d}/, '"')

- if item.respond_to?(:encoding)
- # restore the old encoding
- item.force_encoding(enc)
- end
-
item.strip!
item
end