[rubyripper] 2 new revisions pushed by boukewou...@gmail.com on 2013-01-02 19:23 GMT

1 view
Skip to first unread message

rubyr...@googlecode.com

unread,
Jan 2, 2013, 2:24:18 PM1/2/13
to rubyrippe...@googlegroups.com
2 new revisions:

Revision: 5f1eadcc687c
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Wed Jan 2 11:20:36 2013
Log: An important fix to prevent encoding errors with cuesheets....
http://code.google.com/p/rubyripper/source/detail?r=5f1eadcc687c

Revision: b21f0ce904aa
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Wed Jan 2 11:23:31 2013
Log: Several fixes as proposed in debug mode.
http://code.google.com/p/rubyripper/source/detail?r=b21f0ce904aa

==============================================================================
Revision: 5f1eadcc687c
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Wed Jan 2 11:20:36 2013
Log: An important fix to prevent encoding errors with cuesheets.

If you use multiple file ripping + cuesheets this was not working.
The code was trying to add the cuesheet to each single file, which
is obviously not correct. It should only pack the cuefile if you
have an image rip.

http://code.google.com/p/rubyripper/source/detail?r=5f1eadcc687c

Modified:
/lib/rubyripper/codecs/main.rb

=======================================
--- /lib/rubyripper/codecs/main.rb Sat Sep 29 08:56:42 2012
+++ /lib/rubyripper/codecs/main.rb Wed Jan 2 11:20:36 2013
@@ -122,7 +122,7 @@
when :discId then add(value, "\"#{@disc.freedbDiscid}\"") if
@disc.freedbDiscid
when :discNumber then add(value, @md.discNumber) if
@md.discNumber
when :encoder then add(value, "\"Rubyripper #{$rr_version}\"")
- when :cuesheet then addCuesheet(value)
+ when :cuesheet then addCuesheet(value) if @prefs.image
when :trackname then add(value, @tags.trackname(track))
when :tracknumber then add(value, "#{track}")
when :tracktotal then add(value, "#{@disc.audiotracks}")

==============================================================================
Revision: b21f0ce904aa
Author: Bouke Woudstra <boukew...@gmail.com>
Date: Wed Jan 2 11:23:31 2013
Log: Several fixes as proposed in debug mode.

http://code.google.com/p/rubyripper/source/detail?r=b21f0ce904aa

Modified:
/bin/rubyripper_gtk2
/lib/rubyripper/disc/calcFreedbID.rb
/lib/rubyripper/disc/permissionDrive.rb
/lib/rubyripper/disc/scanDiscCdparanoia.rb
/lib/rubyripper/disc/scanDiscCdrdao.rb
/lib/rubyripper/gtk2/gtkDisc.rb

=======================================
--- /bin/rubyripper_gtk2 Sun Sep 30 04:28:38 2012
+++ /bin/rubyripper_gtk2 Wed Jan 2 11:23:31 2013
@@ -54,6 +54,8 @@
@prefs = prefs ? prefs : Preferences::Main.instance
@shortMessage = short ? short : ShortMessage.new()
@deps = deps ? deps : Dependency.instance
+ @currentInstance = nil
+ @gtkDisc = nil
end

def start
=======================================
--- /lib/rubyripper/disc/calcFreedbID.rb Sun Aug 5 08:37:08 2012
+++ /lib/rubyripper/disc/calcFreedbID.rb Wed Jan 2 11:23:31 2013
@@ -31,6 +31,7 @@
@exec = exec ? exec : Execute.new()
@prefs = prefs ? prefs : Preferences::Main.instance
@deps = deps ? deps : Dependency.instance
+ @freedbString = nil
end

# fetch the freedb string
=======================================
--- /lib/rubyripper/disc/permissionDrive.rb Sun Mar 11 11:26:41 2012
+++ /lib/rubyripper/disc/permissionDrive.rb Wed Jan 2 11:23:31 2013
@@ -29,6 +29,7 @@
def initialize(prefs=nil, deps=nil)
@prefs = prefs ? prefs : Preferences::Main.instance
@deps = deps ? deps : Dependency.instance()
+ @error = nil
end

# before trying to query cdparanoia check if permissions of the drive
are ok
=======================================
--- /lib/rubyripper/disc/scanDiscCdparanoia.rb Thu Oct 11 11:23:11 2012
+++ /lib/rubyripper/disc/scanDiscCdparanoia.rb Wed Jan 2 11:23:31 2013
@@ -38,6 +38,8 @@
@perm = permissionDrive ? permissionDrive : PermissionDrive.new()
@prefs = prefs ? prefs : Preferences::Main.instance
@out = out ? out : $stdout
+ @status = nil
+ @audiotracks = nil
end

# scan the disc for input and return the object
=======================================
--- /lib/rubyripper/disc/scanDiscCdrdao.rb Thu Dec 27 12:21:52 2012
+++ /lib/rubyripper/disc/scanDiscCdrdao.rb Wed Jan 2 11:23:31 2013
@@ -42,6 +42,7 @@
@exec = execute ? execute : Execute.new()
@prefs = @prefs = prefs ? prefs : Preferences::Main.instance
@fileAndDir = fileAndDir ? fileAndDir : FileAndDir.instance()
+ @discType = nil
end

# The scan is called after the initial scan in Disc.
=======================================
--- /lib/rubyripper/gtk2/gtkDisc.rb Thu Dec 27 12:16:49 2012
+++ /lib/rubyripper/gtk2/gtkDisc.rb Wed Jan 2 11:23:31 2013
@@ -27,6 +27,12 @@

attr_reader :display, :error, :selection, :disc

+ def initalize
+ @discInfoTable = nil
+ @trackInfoTable = nil
+ @display = nil
+ end
+
def start
refresh(firsttime = true)
end
Reply all
Reply to author
Forward
0 new messages