How do I force link_to/form helpers to use the superclass name in the path instead subclass?

112 views
Skip to first unread message

Mohamad El-Husseini

unread,
Aug 7, 2012, 12:13:56 PM8/7/12
to rubyonra...@googlegroups.com
I want my helpers to generate paths using a superclass instead of the subclasses. Assuming I have Owner and Member that both inherit from User, rails will use the current objects class name when generating paths:

Let's say current_user is a mod: <%= link_to current_user.name, current_user %> will generate "/mod/:id". I want to force it to generate "/user/:id" regardless of the subclass.

I can name the path:
<%= link_to current_user.name, user_path(current_user) %>

But I still want to use the convenience of just passing the object:
<%= link_to current_user.name, current_user %>

Is this possible?


Peter

unread,
Aug 8, 2012, 10:43:47 AM8/8/12
to rubyonra...@googlegroups.com
You didn't specify the rails version, but I'm pretty sure the answer is no.  In Rails 2.3.14 your link to is eventually calling url_for, which calls polymorphic_url (through polymorphic_path) since you're not passing it a String, Hash or the symbol :back (https://github.com/rails/rails/blob/v2.3.14/actionpack/lib/action_view/helpers/url_helper.rb#L76).  In turn that eventually calls build_named_route_call, which uses RecordIdentifier.plural_class_name(current_user), which is returning the class name (https://github.com/rails/rails/blob/v2.3.14/actionpack/lib/action_controller/polymorphic_routes.rb#L154).  And finally that in turn eventually calls current_user.model_name (https://github.com/rails/rails/blob/v2.3.14/actionpack/lib/action_controller/record_identifier.rb#L100)

You could look into overriding what model name returns for those classes, but that seems really far reaching and dangerous.  I'd just use the path helper since that best represents what you want to do, which is send an Owner or Member object not to /owners/:id or /members/:id but to /users/:id instead; ergo the verbosity doesn't seem bad to me, it helps clarify.

As an alternative, you could also define the /owners/:id and /members/:id routes and point them at UsersController; not sure if that's okay to have the extra routes, but that allows you to keep your shorthand notation, has that map to the expected URL, but lets you DRY the underlying controller class.

\Peter


Mohamad El-Husseini

unread,
Aug 8, 2012, 2:50:06 PM8/8/12
to rubyonra...@googlegroups.com
I'm using Rails 3.2. And I'm pretty sure you can. Basically, to get a form to post to the right model I need to set it up generically. My initial form was:

= simple_form_for @user do |f|

To make it work I had to change it to this:

= simple_form_for :user, url: user_path(@user) do |f|
To work with link helpers, I added this as resource:

resources :owners, path: 'users', controller: 'users'


Dheeraj Kumar

unread,
Aug 8, 2012, 3:03:38 PM8/8/12
to rubyonra...@googlegroups.com
It's simple. Use AR::Base#becomes


Dheeraj Kumar

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonra...@googlegroups.com.
To unsubscribe from this group, send email to rubyonrails-ta...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/-NUfQAxSGDMJ.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Mohamad El-Husseini

unread,
Aug 8, 2012, 3:08:27 PM8/8/12
to rubyonra...@googlegroups.com
Sorry, can you clarify your post a little? What does AR::Base#becomes exactly mean? I'm relatively new to some of this stuff!

Dheeraj Kumar

unread,
Aug 8, 2012, 3:20:51 PM8/8/12
to rubyonra...@googlegroups.com

class User < Person
end

u = User.first
u.class.name #=> User

p = u.becomes(Person)
p.class.name #=> Person


Dheeraj Kumar

To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/zS500RJNLR4J.

Dheeraj Kumar

unread,
Aug 8, 2012, 3:23:10 PM8/8/12
to rubyonra...@googlegroups.com
AR is activerecord
AR::Base is what all active record models inherit from
a#b means i'm talking about method b in class a


Dheeraj Kumar

Mohamad El-Husseini

unread,
Aug 8, 2012, 6:45:17 PM8/8/12
to rubyonra...@googlegroups.com
OK, thanks. But why would I do this instead of just adding the extra resource?

resources :users
resources :owners, controller: 'users', path: 'users'

And in forms I could just call "form_for :user" instead of "form_for @user"?

Peter

unread,
Aug 9, 2012, 11:00:59 AM8/9/12
to rubyonra...@googlegroups.com
On Wednesday, August 8, 2012 1:50:06 PM UTC-5, Mohamad El-Husseini wrote:

To make it work I had to change it to this:

= simple_form_for :user, url: user_path(@user) do |f|

I'm confused, i thought that is what you are trying to avoid?  I.e. you don't want to have to specify user_path(@user), you wanted to just have @user and have it compute the path helper as user_path, instead of owner_path or member_path? In your solution you just put in user_path, which makes your question moot, no?
 
To work with link helpers, I added this as resource:

resources :owners, path: 'users', controller: 'users'

Right, I didn't spell out the code like you did, but this is "As an alternative, you could also define the /owners/:id and /members/:id routes and point them at UsersController".  As a note, with that set of routes defined you should be able to use your original form declaration:

= simple_form_for @user do |f|
 Because simple_form_for will eventually do url_for(@user) like link helpers and therefore as long as owners and members are routed it should work.

\Peter

Peter

unread,
Aug 9, 2012, 11:08:09 AM8/9/12
to rubyonra...@googlegroups.com
On Wednesday, August 8, 2012 5:45:17 PM UTC-5, Mohamad El-Husseini wrote:
OK, thanks. But why would I do this instead of just adding the extra resource?

resources :users
resources :owners, controller: 'users', path: 'users'

The reason would be if you didn't want to expose the urls:

/members/:id
/owners/:id

I.e. with those routes defined if @user is a member with ID 37 then:

link_to 'click here', @user             # => goes to '/members/37'
link_to 'click here', user_path(@user)  # => goes to '/users/37'

So if you just want to be able to do the first line and don't care about the url, map the routes; if you want to exactly duplicate the second line (i.e. your original code, and what would technically have 'helpers to generate paths using a superclass instead of the subclasses') then you could use becomes as such:

link_to 'click here', @user.becomes(User)    # => goes to '/users/37'

However, I personally think the one with user_path is more readable in this case.

\Peter
Reply all
Reply to author
Forward
0 new messages